bugGNU Octave - Bugs: bug #55367, Enable link-all-dependencies for...

 
 

bug #55367: Enable link-all-dependencies for Cygwin

Submitter:  Markus Mützel <mmuetzel>
Submitted:  Thu 03 Jan 2019 11:11:48 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  3 - Low Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 31 Oct 2022 10:30:00 AM UTC, comment #7: 

The CI is back up and running. It looks like these changes didn't disturb building on the tested platforms.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Fri 28 Oct 2022 06:25:22 AM UTC, comment #6: 

In absence of any feedback, I reverted the part of the changeset that enables linking all dependencies for macOS by default.
IIUC, it would be better to avoid that unless it is necessary. I can confirm that it is necessary on Cygwin (or there are missing symbols when trying to link the libraries).

https://hg.savannah.gnu.org/hgweb/octave/rev/ee03da4812fd


If someone can provide feedback if this in indeed necessary on macOS, we could revert this change.

It's probably futile to wait for feedback on this report. So, I'm changing the status back to "ready for test".

Markus Mützel <mmuetzel>
Group administrator
Mon 24 Oct 2022 09:09:17 AM UTC, comment #5: 

I read that Mike Miller's comment #1 meant that linking all dependencies is also necessary on macOS. Could someone please confirm if this is (still) true?

We built on the GitHub runners without that flag. But I find that, e.g., Homebrew adds that flag to the configure step of their build rule for Octave:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/octave.rb#L98

Is that just legacy that was only needed in the past? Or do we still need to enable linking all dependencies on macOS?

Markus Mützel <mmuetzel>
Group administrator
Sun 23 Oct 2022 10:22:31 AM UTC, comment #4: 

I pushed a changeset that enables linking to all dependencies for Cygwin and macOS here:
https://hg.savannah.gnu.org/hgweb/octave/rev/900c7d9f7fdd

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Sat 02 Mar 2019 07:24:48 PM UTC, comment #3: 

Agree that this wouldn't be too hard to implement, but should be done on the dev branch.

Rik <rik5>
Group administrator
Sat 05 Jan 2019 10:55:13 AM UTC, comment #2: 

Hope the new description is correct. Please feel free to change it if it isn't to the point.

I also lowered the priority for this feature request since the workaround is easy: configure with "--enable-link-all-dependencies".

Markus Mützel <mmuetzel>
Group administrator
Thu 03 Jan 2019 09:57:41 PM UTC, comment #1: 

I think it would be fine to look into making the default value of --enable-link-all-dependencies vary depending on the detected build system. Ok to retitle this as such and call it a feature request, and include the macOS preference as well? This would be better worked on and tested on the default branch for Octave 6.

Mike Miller <mtmiller>
Group Member
Thu 03 Jan 2019 11:11:48 AM UTC, original submission:  

As reported in bug #53627, Octave fails to compile with default parameters on cygwin with the following linking error:

config.status: executing liboctave/mk-version-h.sh commands
CXXLD libinterp/dldfcn/__delaunayn__.la
libinterp/dldfcn/.libs/libinterp_dldfcn___delaunayn___la-__delaunayn__.o: In function `free_qhull_memory':
/pub/devel/octave/hg/octave-build/../octave/libinterp/dldfcn/__delaunayn__.cc:84: undefined reference to `warning(char const*, ...)'


Linking reportedly succeeds if configure is run with the "--enable-link-all-dependencies" option.

Should this option be enabled by default on cygwin (and possibly other platforms requiring "-no-undefined")?

Markus Mützel <mmuetzel>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-10-31 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-10-28 mmuetzel StatusNeed Info Ready For Test
        SummaryEnable link-all-dependencies for Cygwin and macOS Enable link-all-dependencies for Cygwin
    2022-10-24 mmuetzel StatusReady For Test Need Info
    2022-10-23 mmuetzel StatusConfirmed Ready For Test
        SummaryEnable link-all-dependencies for systems that need &quot;-no-undefined&quot; Enable link-all-dependencies for Cygwin and macOS
    2019-03-02 rik5 StatusNone Confirmed
    2019-01-05 mmuetzel Priority5 - Normal 3 - Low
        Item GroupBuild Failure Feature Request
        Operating SystemMicrosoft Windows Any
        SummaryLinking fails on cygwin Enable link-all-dependencies for systems that need "-no-undefined"

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code