bugGNU Octave - Bugs: bug #54953, Possible to create uncloseable...

 
 

bug #54953: Possible to create uncloseable figures when using --no-gui-libs option

Submitted by:  Rik <rik5>
Submitted on:  Sun 04 Nov 2018 03:41:45 PM UTC  
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  6.0.90 Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 May 2020 05:12:59 PM UTC, comment #4: 

Thanks for the review and test.

I pushed the change here:
https://hg.savannah.gnu.org/hgweb/octave/rev/809c61402196

Closing as fixed.

Markus Mützel <mmuetzel>
Project Member
Thu 21 May 2020 04:58:25 PM UTC, comment #3: 

I reviewed the patch and it looks good.  It passes the test code I wrote in comment #0.  I think you should push it to stable.

Rik <rik5>
Project Administrator
Thu 21 May 2020 10:17:26 AM UTC, comment #2: 

The attached patch fixes the error for me.

The test suite still passes, and the dump_plot_demos script succeeded for the "qt", "fltk" and "gnuplot" graphics toolkits here.

I was working on the default branch. But since this is a regression, I think the changes should be made on stable (where the patch should also apply).

(file #49136)

Markus Mützel <mmuetzel>
Project Member
Sun 04 Nov 2018 06:04:24 PM UTC, comment #1: 

Confirmed on afadaafd88a2. This is a regression since e80a87f65997, where I originally tested this and I was not able to reproduce.

Mike Miller <mtmiller>
Project Administrator
Sun 04 Nov 2018 03:41:45 PM UTC, original submission:  

Steps to reproduce:

1) Start octave with

./run-octave -f --no-gui-libs

2) then run

graphics_toolkit fltk
figure ('abc', 'def')        # this will throw an error from set()
findall (0)                  # this will make figure 1 visible
close (1)                    # this will not close the figure

The only way to get rid of the figure was to quit Octave.  This also happens when using the gnuplot toolkit.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49136:  bug54953_incomplete_figure.patch added by mmuetzel (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-21 mmuetzel StatusPatch Reviewed => Fixed
        Open/ClosedOpen => Closed
    2020-05-21 rik5 StatusConfirmed => Patch Reviewed
    2020-05-21 mmuetzel Attached File- => Added bug54953_incomplete_figure.patch, #49136
        Releasedev => 6.0.90
    2018-11-04 mtmiller Item GroupOther => Regression
        StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.5