bugGNU Octave - Bugs: bug #54531, zscore: opt argument wrongly...

 
 

bug #54531: zscore: opt argument wrongly checked

Submitter:  Juan Pablo Carbajal <juanpi>
Submitted:  Fri 17 Aug 2018 11:11:15 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  juanpi
Originator Name:  juanpi Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 20 Aug 2018 02:02:51 AM UTC, comment #1: 

Yes, that was incorrect.  I fixed it on stable here (https://hg.savannah.gnu.org/hgweb/octave/rev/dc70b480b9c1).  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Fri 17 Aug 2018 11:11:15 PM UTC, original submission:  

After the change in behavior of isscalar zscore is failing with empty OPT argument, MCV:


zscore (rand (10,1), [], 1)
error: zscore: OPT must be empty, 0, or 1
error: called from
    zscore at line 60 column 7


One just needs to copy the check on opt from std.m, however ...
I know that it is better to fail as soon as possible, but zscore just passes the OPT argument to std doing nothing with it, shouldn't std take care of OPT then?
This way we do not have to maintain two checks on OPT, one of them redundant.

Juan Pablo Carbajal <juanpi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by juanpi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-08-20 avinoam Summaryzscore: opt argument wronly checked zscore: opt argument wrongly checked
    2018-08-20 rik5 StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code