bugGNUstep - Bugs: bug #53941, NSProcessInfo -systemUptime test...

Group
 
 

bug #53941: NSProcessInfo -systemUptime test sometimes fails on GNU/Hurd

Submitter:  Yavor Doganov <yavor>
Submitted:  Sat 19 May 2018 09:55:21 AM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  FredKiefer
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 13 Jul 2018 11:30:36 AM UTC, comment #2: 

Thanks, works for me.  Sorry for missing Windows, I just wasn't careful enough.

I see nothing wrong in making tests conditional based on defines; running the testsuite assumes a configured tree.  Besides, that is already done for some tests that rely on ICU or libxml being available.

Yavor Doganov <yavor>
Sun 27 May 2018 12:19:00 PM UTC, comment #1: 

I fixed this test somewhat differently by marking it as hopeful. First off I didn't like the idea of making tests conditional on specific defines and there was also the case of WIN32 missing.

With the current solution the test will sometimes fail on GNU Hurd but in that case it will only be reported as a dashed hope and your build should proceed.

Fred Kiefer <FredKiefer>
Group Member
Sat 19 May 2018 09:55:21 AM UTC, original submission:  

On GNU/Hurd, procfs is optional -- the system works just as well without it.  Debian's hurd-i386 buildds are configured with procfs but for some reason from time to time the test (as well as the configure test for procfs) fails.  See https://lists.debian.org/debian-hurd/2018/02/msg00017.html for details.

As this method is a no-op if neither procfs nor sysctlbyname are available I'd suggest to not compile/run the test if these conditions are not met.  Patch attached.

Yavor Doganov <yavor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by yavor (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-11 FredKiefer StatusReady For Test Fixed
        Open/ClosedIn Test Closed
    2018-05-27 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen In Test
    2018-05-19 yavor Attached File- Added conditional-systemUptime-test.patch, #44178

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code