bugGNU Octave - Bugs: bug #53545, GLCanvas.cc:141:44: warning:...

 
 

bug #53545: GLCanvas.cc:141:44: warning: catching polymorphic type ‘class octave::execution_exception’ by value

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Sun 01 Apr 2018 06:41:36 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Missed Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 02 Apr 2018 05:23:02 AM UTC, comment #2: 

Looks fine as of d3baac355a2c (stable) tip

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 02 Apr 2018 05:17:51 AM UTC, comment #1: 

I changed do_print in GLCanvas.cc to catch the execution_exception by reference, which is what is done everywhere else in Octave.  See http://hg.savannah.gnu.org/hgweb/octave/rev/d3baac355a2c.

Marking as Ready for Test.

Rik <rik5>
Group administrator
Sun 01 Apr 2018 06:41:36 PM UTC, original submission:  

With gcc 8.01. (hg id 53440f9bffba (stable) tip):


../libgui/graphics/GLCanvas.cc: In member function ‘virtual void QtHandles::GLCanvas::do_print(const QString&, const QString&, const graphics_handle&)’:
../libgui/graphics/GLCanvas.cc:141:44: warning: catching polymorphic type ‘class octave::execution_exception’ by value [-Wcatch-value=]
         catch (octave::execution_exception e)
                                            ^


Dmitri.
--


Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-02 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-04-02 rik5 StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code