bugGNU roff - Bugs: bug #53243, regression: .hy not working in...

 
 

bug #53243: regression: .hy not working in latest groff build

Submitter:  Dave <barx>
Submitted:  Wed 28 Feb 2018 01:33:52 AM UTC
   
 
Category:  Core Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  wl
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 16 Jun 2022 12:30:23 AM UTC, comment #5: 


comment #4:

> comment #3:
> > Nothing in the tree or commit history explicitly mentions this bug
>
> The commit message for commit b5aaab51 is very terse, but its associated ChangeLog entry does mention fixing this bug.


Ah, somehow I overlooked that.  I probably transposed digits when grepping.  Thanks, Dave!

G. Branden Robinson <gbranden>
Group administrator
Wed 15 Jun 2022 06:56:34 PM UTC, comment #4: 

comment #3:

> Nothing in the tree or commit history explicitly mentions this bug


The commit message for commit b5aaab51 is very terse, but its associated ChangeLog entry does mention fixing this bug.

Dave <barx>
Group Member
Wed 15 Jun 2022 05:44:15 PM UTC, comment #3: 

Nothing in the tree or commit history explicitly mentions this bug, but it seems likely that bug #53196 and this one were fixed together.


commit 4b299723a61cfa2dc8ff57224d681b42e5d10ded
Author: Werner Lemberg <wl@gnu.org>
Date:   Fri Mar 2 18:56:42 2018 +0100

    Hyphenation exceptions in pattern files now obey `.hy' (#53196).

    * src/roff/troff/env.cpp (hyphen_trie::read_patterns_file): Mark
    `\hyphenation' entries with a trailing space.
    (hyphen_trie::insert_hyphenation): Updated.
    (hyphenate): Make `\hyphenation' entries obey `.hy' restrictions.

    * doc/groff.texi (.hy): Updated.


G. Branden Robinson <gbranden>
Group administrator
Thu 19 Apr 2018 03:06:06 AM UTC, comment #2: 

Yes, it works now.  Thank you!

Dave <barx>
Group Member
Thu 01 Mar 2018 07:32:03 PM UTC, comment #1: 

Should be fixed now in git, please test.

Werner LEMBERG <wl>
Group administrator
Wed 28 Feb 2018 01:33:52 AM UTC, original submission:  

Bjarni Ingi Gislason pointed out this bug in a comment in bug #53196.  That bug documents a different (but related) issue, so I'm opening up this new bug report.  As this is a regression since the last release, this should be addressed before the new version of groff is released.

The problem is that .hy values 4 and 8 seem not to be honored anymore.  I've confirmed that ".hy 8" works in the official groff release, but not in the latest code built from git.  I've not yet backtracked to see which commit introduced the bug.

Three lines of groff input illustrate this:

groff -a << EOF
.hy 8
.ll 1i
He is a skilled acrobat.
EOF

Running this on a groff built from current git code produces:

<beginning of page>
He is a skilled ac<hy>
robat.

".hy 8" should prevent the word "acrobat" from being hyphenated after two characters.  And indeed, when run on the latest released groff, it does so, pushing the whole word onto the next line.

(Bjarni's proposed solution is to remove these two values from groff's .hy documentation and emit a warning if the user uses them.  However, a change to functionality that has been documented and working in groff for two decades needs to be discussed on the groff email list before being implemented.  I will leave it to Bjarni to initiate this discussion if he feels that is the best way to proceed.)

Dave <barx>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by barx (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone Core
    2018-03-01 wl StatusNone Fixed
        Assigned toNone wl
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code