bugGNU FreeIPMI - Bugs: bug #53193, ipmi-config compatibility scripts ...

 
 

bug #53193: ipmi-config compatibility scripts mangle parameters through shell

Submitter:  None
Submitted:  Tue 20 Feb 2018 04:34:08 PM UTC
   
 
Category:  bmc-config Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Improper Behaviour
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 20 Feb 2018 09:18:55 PM UTC, comment #2: 

Please credit "Jö Fahlke <jorrit@jorrit.de>" (though it's hardly necessary, given I didn't even do any testing).

I forgot to clearly mention in the original report that the other *-config compatibility scripts suffer from the same problem.

Jö Fahlke <exbart>
Tue 20 Feb 2018 06:14:47 PM UTC, comment #1: 

You're right, that seems much simpler.

Would you like to submit a patch?  Or just let me know the name/email you want me to give credit to.

Albert Chu <chu11>
Group administrator
Tue 20 Feb 2018 04:34:08 PM UTC, original submission:  

bmc-config and the other compatibility scripts seem to let the shell mangle their parameters before passing them to ipmi-config.


root@epic:~# ls
bmc-core.conf
root@epic:~# bmc-config -g '*' -o
invalid category 'bmc-core.conf' specified


(yeah, I was attempting to make a backup of all setting from all categories...)

This is because of the rather convoluted way that bmc-config patches the --category=core option into the command line.  A much simpler bmc-config.in not suffering from the same problem would be:


#!/bin/sh
exec @CONFIGSBINDIR@/ipmi-config --category=core "$@"


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by exbart (Posted a comment)
  • -email is unavailable- added by chu11 (Posted a comment)
  • -email is unavailable- added by exbart
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-02 chu11 Open/ClosedOpen Closed
    2018-02-20 exbart Carbon-Copy- Added exbart
    2018-02-20 exbart Carbon-CopyRemoved -email is unavailable- -
    2018-02-20 exbart Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code