bugGNU Octave - Bugs: bug #53176, Variable Editor shows placeholder...

 
 

bug #53176: Variable Editor shows placeholder instead of the variable after executing 'clear all'

Submitter:  Sahil <batterylow>
Submitted:  Sat 17 Feb 2018 01:06:52 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Sahil Yadav Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 09 Apr 2018 04:43:23 AM UTC, comment #2: 

Somewhere along the line this was fixed and the format for printing no longer uses '%d' but '%1' as it should.  The fix will be part of the 4.4 release.  Closing report.

Rik <rik5>
Group administrator
Sat 17 Feb 2018 08:03:42 PM UTC, comment #1: 

"As a side note, if someone can explain me when the following line will be used in the patch ?
I don't think we will want to print the statement other than a string. (for which role== Qt::DisplayRole)"

The "subclassing" is described here:

http://doc.qt.io/qt-5/qabstractitemmodel.html#subclassing

of which the following seems most pertinent:

"Most models provide at least a textual representation of item data for the Qt::DisplayRole, and well-behaved models should also provide valid information for the Qt::ToolTipRole and Qt::WhatsThisRole. Supporting these roles enables models to be used with standard Qt views. However, for some models that handle highly-specialized data, it may be appropriate to provide data only for user-defined roles."

I think what this means is that Qt entities like QTextEdit handle data in a general way where some of its features may want a tooltip representation of the data, or an icon representation of the data, etc.  In this case Octave is being a bit incomplete in just putting and X for any other role other than displaying it, say, in a QTextEdit window.

Dan Sebald <sebald>
Sat 17 Feb 2018 01:06:52 PM UTC, original submission:  

Though this is a really minor bug, but try the following code in GUI:

x = 1;
openvar x;
clear all;


The variable editor will close the variable and puts up


Variable %d not found.


(See attached png as an example)

I changed the placeholder so that the variable's name shows up in quotes. Patch included.

As a side note, if someone can explain me when the following line will be used in the patch ?

return QVariant (QString ("x"));

I don't think we will want to print the statement other than a string. (for which role== Qt::DisplayRole)

Sahil <batterylow>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43340:  ss.png added by batterylow (18KiB - image/png)
file #43341:  53176.diff added by batterylow (826B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by batterylow (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-09 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2018-02-17 batterylow Attached File- Added ss.png, #43340
        Attached File- Added 53176.diff, #43341

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code