bugGNU Octave - Bugs: bug #53137, Variable Editor: m_table_colors...

 
 

bug #53137: Variable Editor: m_table_colors list should be used with range-checked indices

Submitted by:  Dan Sebald <sebald>
Submitted on:  Mon 12 Feb 2018 10:49:21 PM UTC  
 
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Segfault, Bus Error, etc.
Status: Patch SubmittedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 15 Feb 2018 08:39:44 PM UTC, comment #2:

Pushed here:

http://hg.savannah.gnu.org/hgweb/octave/rev/cea7557d91ef

John W. Eaton <jwe>
Project Administrator
Mon 12 Feb 2018 10:56:19 PM UTC, comment #1:

Patch attached.

(file #43266)

Dan Sebald <sebald>
Mon 12 Feb 2018 10:49:21 PM UTC, original submission:

In doing some debugging on another issue, I came across a consistent crash at launch that I tracked down to insufficient colors in the m_table_colors list. In other words, if the following is not done in the variable_editor constructor:

Octave will crash.

This isn't a bug per se, since it's only in modifications that I came across this. However, Octave shouldn't crash because some color table isn't initialized sufficiently big. Also, it wouldn't surprise me if some scenario is possible in which the resource_manager::varedit_color_chars ().length () is different between the time of initialization and notice_settings() update, e.g., a color-theme change in the OS desk top.

Changeset in a moment...

Dan Sebald <sebald>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by sebald (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 15 Feb 2018 08:39:44 PM UTCjweStatusNone=>Patch Submitted
      Open/ClosedOpen=>Closed
    Mon 12 Feb 2018 10:56:19 PM UTCsebaldAttached File-=>Added octave-variable_editor_m_table_colors-djs2018feb12.patch, #43266

    Back to the top


    Powered by Savane 3.1-cleanup1