bugGNU Octave - Bugs: bug #53049, Warnings during MXE compile

 
 

bug #53049: Warnings during MXE compile

Submitter:  Rik <rik5>
Submitted:  Fri 02 Feb 2018 09:35:27 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 05 Feb 2018 09:28:38 PM UTC, comment #4: 

I confirm that the warning messages have disappeared.

Rik <rik5>
Group administrator
Sun 04 Feb 2018 12:09:40 PM UTC, comment #3: 

The warnings no longer appear for me. Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Sat 03 Feb 2018 09:19:24 PM UTC, comment #2: 

I pushed a change here that should avoid that warning:
http://hg.savannah.gnu.org/hgweb/octave/rev/328053e1d232

Markus Mützel <mmuetzel>
Group administrator
Sat 03 Feb 2018 04:22:05 PM UTC, comment #1: 

Gnulib has a wrapper for that function [1]. However, it doesn't provide an implementation for MinGW.
Since the function "signal_watcher" is only used inside an "#if ! defined (_WIN32_)" block, it probably makes sense to put the hole function inside an #if block as well.

[1] https://www.gnu.org/software/gnulib/manual/html_node/sigwait.html

Markus Mützel <mmuetzel>
Group administrator
Fri 02 Feb 2018 09:35:27 PM UTC, original submission:  

Looking at the log for compiling Octave with MXE I find


/home/rik/wip/Projects_Mine/mxe-octave/tmp-default-octave/octave-4.3.0+/liboctave/wrappers/signal-wrappers.c: In function 'signal_watcher':
/home/rik/wip/Projects_Mine/mxe-octave/tmp-default-octave/octave-4.3.0+/liboctave/wrappers/signal-wrappers.c:667:11: warning: implicit declaration of function 'sigwait'; did you mean 'signal'? [-Wimplicit-function-declaration]
       if (sigwait (async_signals, &sig_caught))
           ^~~~~~~
           signal
At top level:
/home/rik/wip/Projects_Mine/mxe-octave/tmp-default-octave/octave-4.3.0+/liboctave/wrappers/signal-wrappers.c:655:1: warning: 'signal_watcher' defined but not used [-Wunused-function]
 signal_watcher (void *arg)


Something is obviously different about the Windows environment, because I don't get thes warnings when doing a native compile on Linux, and sigwait is supposed to be in <signal.h> which is getting included, from what I can tell.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-04 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-02-03 mmuetzel StatusNone Ready For Test

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code