bugGNU Octave - Bugs: bug #52838, implement print keyword 'fillpage'

 
 

bug #52838: implement print keyword 'fillpage'

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Mon 08 Jan 2018 08:03:13 PM UTC  
 
Category:  Octave Function Severity:  1 - Wish
Priority:  3 - Low Item Group:  Feature Request
Status:  Patch Submitted Assigned to:  None
Originator Name:  Avinoam Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 11 Nov 2018 02:41:11 AM UTC, comment #9:

@jwe: Did you want to check in the patch on this bug report. You were only waiting for the Author field which "Jun Wang" has provided.

Rik <rik5>
Project Administrator
Sun 28 Oct 2018 08:43:03 AM UTC, comment #8:

Thanks for your review. You could use name "Jun Wang" in changeset and contributors file.

JunWang <junwang>
Fri 26 Oct 2018 07:20:11 PM UTC, comment #7:

JunWang: Sorry for the delay in looking at this. I'd like to apply this changeset. Please let me know how you'd like to be credited so I can give you credit in the changeset and add your name to the contributors file.

John W. Eaton <jwe>
Project Administrator
Thu 22 Mar 2018 06:10:41 PM UTC, comment #6:

I add '-fillpage' and '-bestfit' for print.
These resize options don't change 'paperposition' property of figure.

(file #43633)

JunWang <junwang>
Tue 09 Jan 2018 08:23:37 PM UTC, comment #5:

This looks really easy to implement if someone wants to try it. Just need to detect the option and then set the PaperPosition property. Should check with Matlab, does using 'bestfit' alter the PaperPosition property or does it save/restore the current value during printing?

Rik <rik5>
Project Administrator
Mon 08 Jan 2018 08:42:49 PM UTC, comment #4:

This seems to be a new Matlab option to print:

https://www.mathworks.com/help/matlab/creating_plots/save-figure-at-specific-size-and-resolution.html

Maybe this should also be marked as a feature request to implement this option, as well as "-bestfit".

Rik <rik5>
Project Administrator
Mon 08 Jan 2018 08:40:20 PM UTC, comment #3:

From the help text for print

So for "-fillpage" Octave is trying the handle "illpage" which obviously isn't valid. It seems the print function is behaving as it should.

Rik <rik5>
Project Administrator
Mon 08 Jan 2018 08:31:10 PM UTC, comment #2:

Is '-fillpage' a Matlab option for print? I don't find it in any of the Octave help text

Rik <rik5>
Project Administrator
Mon 08 Jan 2018 08:06:44 PM UTC, comment #1:

sorry, markup problems:

The bug is triggered in line 157 of __print_parse_opts__

a quick and dirty fix is to change line 159 to

and move lines 159-160 before line 157

Avinoam Kalma <avinoam>
Project Member
Mon 08 Jan 2018 08:03:13 PM UTC, original submission:

The bug is triggered in line 157 of __print_parse_opts__

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43633:  print-resize-option.patch added by junwang (4KiB - text/x-patch - implementation of 'fillpage' and 'bestfit')

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by junwang (Updated the item)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by avinoam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-10-26 jwe Priority5 - Normal => 3 - Low
        Item GroupMatlab Compatibility => Feature Request
        StatusConfirmed => Patch Submitted
    2018-03-22 junwang Attached File- => Added print-resize-option.patch, #43633
    2018-01-27 rik5 Severity3 - Normal => 1 - Wish
        Release4.2.1 => dev
        Summaryproblem with print keyword 'fillpage' => implement print keyword 'fillpage'
    2018-01-09 rik5 Item GroupIncorrect Result => Matlab Compatibility
    2018-01-08 rik5 StatusWorks For Me => Confirmed
    2018-01-08 rik5 StatusNeed Info => Works For Me
    2018-01-08 rik5 StatusNone => Need Info
    2018-01-08 avinoam Summaryproblem with print keyword 'filpage' => problem with print keyword 'fillpage'

    Back to the top


    Powered by Savane 3.3