bugGNU Octave - Bugs: bug #52235, GUI: auto close...

 
 

bug #52235: GUI: auto close "endcase" after typing "case" keyword in smart indention feature, if enabled.

Submitter:  Kai Torben Ohlhus <siko1056>
Submitted:  Mon 16 Oct 2017 02:14:34 PM UTC
   
 
Category:  GUI Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 25 Oct 2017 01:30:03 PM UTC, comment #7: 

Sorry, I really meant "now" in comment #5.

Kai Torben Ohlhus <siko1056>
Group Member
Tue 24 Oct 2017 08:05:28 PM UTC, comment #6: 

Thanks for the feedback. Closing the bug as fixed (assuming you meant "Now").

Torsten Lilge <ttl>
Group Member
Tue 24 Oct 2017 02:30:40 PM UTC, comment #5: 

And thank you again Torsten.  Not everything works for me and have nothing more to complain.

Kai Torben Ohlhus <siko1056>
Group Member
Sun 22 Oct 2017 06:53:41 PM UTC, comment #4: 

I hope to have addressed all remaining issues in changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/37190507b5d7
Changing to "Ready For Test" before closing precipitously again.

Torsten Lilge <ttl>
Group Member
Sat 21 Oct 2017 10:10:58 PM UTC, comment #3: 

Thank you for the fix of comment #1 Torsten.  Unfortunately, I can confirm the issue of comment #2, but for the switch statement it works like a charm.

Kai Torben Ohlhus <siko1056>
Group Member
Sat 21 Oct 2017 06:03:18 PM UTC, comment #2: 

Thank you for the fix.
I still see a similar issue when I am typing "unwind_protect_cleanup": Hitting the enter key adds a new line with "endunwind_protect_cleanup". It better should add a "endunwind_protect" (or nothing since a correct block is inserted when I type "unwind_protect" and hit the enter key).
Re-opening this bug because the fix should be very similar.

Markus Mützel <mmuetzel>
Group administrator
Sat 21 Oct 2017 06:43:22 AM UTC, comment #1: 

Thanks for the report. I think its more than a minor nuance, when a feature produces invalid code :-)
The issue should be fixed with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/d0cee5e09879

Torsten Lilge <ttl>
Group Member
Mon 16 Oct 2017 02:14:34 PM UTC, original submission:  

Thank you for that auto closing feature!  I just found a minor nuance, while using the switch statement:


switch ...
  case
  endcase
endswitch


is not valid Octave syntax [1], but the auto complete suggests this while typing, if that feature is enabled.

I think "case" has to be treated separately in regexp [2].

Kai.


[1]: https://www.gnu.org/software/octave/doc/interpreter/The-switch-Statement.html

[2]: http://hg.savannah.gnu.org/hgweb/octave/file/9fab3273ff26/libgui/src/m-editor/octave-qscintilla.cc#l451

Kai Torben Ohlhus <siko1056>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by siko1056 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-10-24 ttl StatusWorks For Me Fixed
        Open/ClosedOpen Closed
    2017-10-24 siko1056 StatusReady For Test Works For Me
    2017-10-22 ttl StatusNone Ready For Test
    2017-10-21 mmuetzel StatusFixed None
        Open/ClosedClosed Open
    2017-10-21 ttl StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code