bugGNU Octave - Bugs: bug #51935, Problem with meta.class.fromName

 
 

bug #51935: Problem with meta.class.fromName

Submitter:  Avinoam Kalma <avinoam>
Submitted:  Mon 04 Sep 2017 03:07:14 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Avinoam Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 21 Sep 2017 08:57:32 PM UTC, comment #5: 

I pushed the changeset here:

http://hg.savannah.gnu.org/hgweb/octave/rev/3645139bd28f

Closing report.

John W. Eaton <jwe>
Group administrator
Sun 10 Sep 2017 09:33:27 PM UTC, comment #4: 

Can anyone  check this patch and push it?

Avinoam Kalma <avinoam>
Group Member
Thu 07 Sep 2017 05:56:53 PM UTC, comment #3: 

The patch fixed the bug for me, thanks.

Avinoam Kalma <avinoam>
Group Member
Wed 06 Sep 2017 05:20:38 PM UTC, comment #2: 

Thanks, I will check test this patch.

Avinoam Kalma <avinoam>
Group Member
Wed 06 Sep 2017 12:44:32 AM UTC, comment #1: 

I wrote a few line patch for this problem.

This problem is in pt-eval.cc in function tree_evaluator::visit_index_expression. It's connected to the fact that indexing_object was properly evaluated only before starting the indexing in line 1299. It needs to be evaluated after getting every partial_expr_val.

I also added a test for this problem under test/classdef/classdef.tst.

(file #41740)

Piotr Held <jsoh425>
Mon 04 Sep 2017 03:07:14 PM UTC, original submission:  


Octave 4.2.1


>> mc = meta.class.fromName('inputParser')
mc =

<object meta.class>


Octave 4.3.0+ (hg_id = 21d2114476a4)


>> mc = meta.class.fromName('inputParser')
error: fromName: invalid number of parameters


Avinoam Kalma <avinoam>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41740:  patch_bug51935.diff added by jsoh425 (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by jsoh425 (Updated the item)
  • -email is unavailable- added by avinoam (Submitted the item)
  • -email is unavailable- added by avinoam
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-21 jwe StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2017-09-06 avinoam StatusNone Patch Submitted
    2017-09-06 jsoh425 Attached File- Added patch_bug51935.diff, #41740
    2017-09-04 avinoam Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code