GNU nano - Bugs: bug #51770, nano locks up when tab size is...
You are not allowed to post comments on this tracker with your current authentication level.
bug #51770: nano locks up when tab size is larger than screen width
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Wed 16 Aug 2017 10:14:30 PM UTC | ||
Severity: | 5 - Blocker | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Tue 22 Aug 2017 02:58:06 PM UTC, comment #12: |
Benno Schulenberg <bens> |
Thu 17 Aug 2017 07:38:23 PM UTC, comment #11: Argh, no, the lockup from the other bug was caused by my previously incorrect fix for it. (All these tab issues are making me a bit confused.) I guess this bug does occur in 2.8.6 after all, but no matter, it's being fixed. |
David Lawrence Ramsey <dolorous> |
Thu 17 Aug 2017 07:33:00 PM UTC, comment #10: Good to know on your terminal size. I think that lockup may be the other bug, which I'll report momentarily (I haven't built 2.8.6 with debugging info to check with gdb). |
David Lawrence Ramsey <dolorous> |
Thu 17 Aug 2017 07:16:30 PM UTC, comment #9: Well, I've just tried with 2.8.6, and nano locks up immediately after the first <Left> or <Right> when running:
|
Benno Schulenberg <bens> |
Thu 17 Aug 2017 06:58:20 PM UTC, comment #8: Yes, that one. |
David Lawrence Ramsey <dolorous> |
Thu 17 Aug 2017 06:24:41 PM UTC, comment #7: You mean bug #51671, right? The support for two-column spaces. |
Benno Schulenberg <bens> |
Thu 17 Aug 2017 06:05:38 PM UTC, comment #6: Thank you.
|
David Lawrence Ramsey <dolorous> |
Thu 17 Aug 2017 05:50:00 PM UTC, comment #5: Thanks for the patches. The final fix has been pushed as f08d169a. The correction for <Left> and <Right> I have implemented a bit differently, in commit cf14ee2e.
|
Benno Schulenberg <bens> |
Thu 17 Aug 2017 04:41:35 PM UTC, comment #4: The other problem is that do_left() and do_right() are calling chunk_for() regardless of whether we're in softwrap mode or not, which is definitely an oversight. The attached new patch fixes that.
|
David Lawrence Ramsey <dolorous> |
Thu 17 Aug 2017 04:16:39 PM UTC, comment #3: To be clear, my reproduction recipe is:
|
Benno Schulenberg <bens> |
Thu 17 Aug 2017 04:05:15 PM UTC, comment #2: The patch is effective. But... it strikes me as absurd: why does get_softwrap_breakpoint() get called when we're not in softwrap mode? Where does that happen? |
Benno Schulenberg <bens> |
Thu 17 Aug 2017 02:54:04 AM UTC, comment #1: Another way to reproduce it is as follows:
|
David Lawrence Ramsey <dolorous> |
Wed 16 Aug 2017 10:14:30 PM UTC, original submission:
This can be reproduced as follows:
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-28 | bens | Open/Closed | Open | Closed | |
2017-08-22 | bens | Severity | 4 - Important | 5 - Blocker | |
Summary | with current git, nano can lock up with overly large tab sizes relative to screen width | nano locks up when tab size is larger than screen width | |||
2017-08-17 | bens | Severity | 3 - Normal | 4 - Important | |
2017-08-17 | bens | Status | In Progress | Fixed | |
Assigned to | None | dolorous | |||
2017-08-17 | dolorous | Attached File | - | Added 0001-weeding-don-t-call-chunk_for-outside-of-softwrap-mod.patch, #41555 | |
2017-08-17 | bens | Status | None | In Progress | |
2017-08-17 | dolorous | Summary | with current git, nano can lock up with overly large tab sizes | with current git, nano can lock up with overly large tab sizes relative to screen width | |
2017-08-16 | dolorous | Attached File | - | Added fix-tab-lockup.patch, #41549 |
Powered by Savane 3.13-f8d8.
Corresponding source code
The problem was not limited to git: 2.8.6 will immediately lock up whenever the tabsize is ten percent larger than the screen.