bugGNU Octave - Bugs: bug #51717, bad colorbar placement (regression...

 
 

bug #51717: bad colorbar placement (regression from 4.2)

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Thu 10 Aug 2017 04:02:50 AM UTC
   
 
Category:  Plotting with OpenGL Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 23 Aug 2017 08:39:51 AM UTC, comment #15: 

Thanks, I pushed the patch after removing trailing whitespaces.

Closing report as fixed.

Pantxo Diribarne <pantxo>
Group Member
Tue 22 Aug 2017 08:07:46 PM UTC, comment #14: 

@Pantxo: Seems like the patch is ready to commit.  Can you strip trailing whitespace before you do so?  I noticed an extra space at the end of a line in the docstring for subplot.

Rik <rik5>
Group administrator
Tue 22 Aug 2017 08:59:12 AM UTC, comment #13: 

@Pantxo: see comment #11 (checked with the old patch, after adding the missing x, on Win-10 machine)

Avinoam Kalma <avinoam>
Group Member
Tue 22 Aug 2017 08:32:36 AM UTC, comment #12: 

@Avinoam: indeed I forgot to add the "x" after copy/paste. I attached a modified patch.

(file #41614)

Pantxo Diribarne <pantxo>
Group Member
Tue 22 Aug 2017 07:42:37 AM UTC, comment #11: 

The results looks good, see attached file.
Checking other demos, I did not see problem



Avinoam Kalma <avinoam>
Group Member
Mon 21 Aug 2017 10:28:13 PM UTC, comment #10: 

There seems to be a typo in the patch


+## @deftypefn  {} {} subplot (@var{rows}, @var{cols}, @var{index}, @var{hax})


should be


+## @deftypefnx  {} {} subplot (@var{rows}, @var{cols}, @var{index}, @var{hax})


(deftypefnx  and not deftypefn)

Avinoam Kalma <avinoam>
Group Member
Mon 21 Aug 2017 09:34:57 AM UTC, comment #9: 

The problem is that "newplot" now removes all listeners from the axes, including those needed for subplot alignment.
I attached a patch that fixes this issue for me:

  • subplot.m is modified to include a "subplot (R,C, IDX, HAX)" call form: this is ML compatible; it turns HAX into a subplot.
  • newplot calls subplot to reinstall listeners after resetting the axes.


(file #41605)

Pantxo Diribarne <pantxo>
Group Member
Thu 10 Aug 2017 05:40:33 PM UTC, comment #8: 

With Doug's fingering of the problem cset I went and compiled revision 23012 and 23013, and I also can verify that 23013 introduced the problem.

Rik <rik5>
Group administrator
Thu 10 Aug 2017 05:15:36 PM UTC, comment #7: 

yes ccache
I start going back by powers of 2 ie.
back 128 and if still bad go
back 256 etc.
powers of 2 is most efficient, as you know.

17 min for a full ./bootstrap to ./run-octave.

most of the time much less.

Doug Stewart <dastew>
Thu 10 Aug 2017 05:09:10 PM UTC, comment #6: 

Are you using ccache as well?

Your computer, indeed, must be very fast.  A 7-month old bisection would typically take me close to a day to perform.

Rik <rik5>
Group administrator
Thu 10 Aug 2017 05:05:13 PM UTC, comment #5: 

I just copied #7 and made an mfile.
I did this manually I did not use a bisect command if there is one.

:-)
I also have a fast computer

Doug Stewart <dastew>
Thu 10 Aug 2017 04:45:43 PM UTC, comment #4: 

I am curious -- what did you use as test for bisect?

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 10 Aug 2017 04:07:34 PM UTC, comment #3: 

@Doug: Wow, thanks for doing the bisection.  That is a long time a go indeed.  I'm adding Pantxo to the CC list for this bug since he checked in cset 23013.  I happen to know that he is on summer holiday right now, so don't expect an answer for a few weeks.

Rik <rik5>
Group administrator
Thu 10 Aug 2017 03:58:27 PM UTC, comment #2: 

I bisected to

Changeset:
23013 (5dca1727ce94) cla.m, newplot.m: make use of reset function to cleanup listeners (bug #49980). …


this 7 months go!

Doug Stewart <dastew>
Thu 10 Aug 2017 04:52:23 AM UTC, comment #1: 

Confirmed.  I don't run the demos all that frequently, but this feels like a fairly new regression.  Maybe try hg bisect to find the problem changeset?

Rik <rik5>
Group administrator
Thu 10 Aug 2017 04:02:50 AM UTC, original submission:  

margin between plot and colorbar is incorrect (in some orientations).
See e.g. "demo colorbar". Demo #7 is attached. Good plot made by octave-4.2.1, bad on by hg id cb8251337689.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41614:  subplot2.patch added by pantxo (7KiB - text/x-patch)
file #41610:  colorbar_07.png added by avinoam (38KiB - image/png)
file #41605:  subplot.patch added by pantxo (7KiB - text/x-patch)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by pantxo (Updated the item)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by dastew (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-23 pantxo StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2017-08-22 pantxo Attached File- Added subplot2.patch, #41614
    2017-08-22 avinoam Attached File- Added colorbar_07.png, #41610
    2017-08-21 pantxo Attached File- Added subplot.patch, #41605
        StatusConfirmed Patch Submitted
    2017-08-11 rik5 Dependencies- bugs #51731 is dependent
    2017-08-10 rik5 Carbon-Copy- Added pantxo
    2017-08-10 rik5 Item GroupNone Regression
        StatusNone Confirmed
        Summarybad colorbar placement bad colorbar placement (regression from 4.2)
    2017-08-10 dasergatskov Attached File- Added bad_colorbar_cb8251337689.png, #41470
        Attached File- Added good_colorbar_o421.png, #41471

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code