bugGNU Octave - Bugs: bug #51680, some LDFLAGS variables may be a...

 
 

bug #51680: some LDFLAGS variables may be a space instead of empty string, throwing off other tests

Submitter:  Mike Miller <mtmiller>
Submitted:  Mon 07 Aug 2017 04:12:19 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Installation Failure
Status:  Fixed Assigned to:  mtmiller
Originator Name:  Open/Closed:  * Closed
Release:  * 4.2.1 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 07 Aug 2017 03:31:08 PM UTC, comment #4: 

Pushed on stable and merged to default

https://hg.savannah.gnu.org/hgweb/octave/rev/6ae0292aaa5c

Now retesting the complete build on 14.04.

Mike Miller <mtmiller>
Group Member
Mon 07 Aug 2017 03:27:02 PM UTC, comment #3: 

I'm throwing a sed on the end of each pkg-config invocation, testing now. There may be ways to rely on shell string expansion, but sed is the safest and most portable.

Mike Miller <mtmiller>
Group Member
Mon 07 Aug 2017 03:16:34 PM UTC, comment #2: 

Is there something magical in shell syntax that can filter spaces, or do you have to resort to sed or some such utility?


Rik <rik5>
Group administrator
Mon 07 Aug 2017 03:09:56 PM UTC, comment #1: 

Dug into the pkg-config history to determine that this only affects users with pkg-config < 0.28. This is basically Ubuntu 14.04 and older and CentOS 7 and older.

It's unfortunate but I think we should address this, so I'm going to push a change on stable that cleans up the output of pkg-config to ensure there are no empty strings that are actually space characters.

This should fix mysterious build problems I've been seeing where I need to install all the development libraries that Octave was built with in order to build a trivial oct file.

Mike Miller <mtmiller>
Group Member
Mon 07 Aug 2017 04:12:19 AM UTC, original submission:  

On Ubuntu 14.04, I find that some pkg-config commands may return what appears to be an empty string, but is actually a space character. There are other tests in configure and possibly elsewhere in the code base that test for empty strings, for example


if test -n "$QT_LDFLAGS"; then
...


which is breaking the build configuration further down the line, for example the set of library dependencies that are encoded in mkoctfile.

I'm working on a workaround for this that I can apply as a patch to the 4.2.1 release, and will post again when I get something working.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-07 mtmiller StatusIn Progress Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code