bugGNU troff - Bugs: bug #51646, [PATCH] src: Remove bloody empty...

 
 

bug #51646: [PATCH] src: Remove bloody empty space at end of lines

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Thu 03 Aug 2017 12:35:33 AM UTC  
 
Category:  None Severity:  2 - Minor
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  G. Branden Robinson <gbranden>
Open/Closed:  Closed Planned Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Nov 2017 01:59:12 PM UTC, comment #2: 

Closing as "won't fix" per Bertrand's response.  However I share Bjarni's antipathy for junky trailing whitespace, and plan to clean it up wherever I can, collaterally with more substantive changes.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Fri 18 Aug 2017 04:40:32 PM UTC, comment #1: 

I think whitespace issues should be manually fixed only where code changes were made; applying your patch would make git history (with `git blame') less easy to follow.

Bertrand Garrigues <bgarrigues>
Project Administrator
Thu 03 Aug 2017 12:35:33 AM UTC, original submission:  

From 2a34e4f18c2588187ad7ca78b7fbef864201204d Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Thu, 3 Aug 2017 00:13:14 +0000
Subject: [PATCH] Remove bloody empty space at end of lines

  Programmers did not clean up their dirt they left after doing their work.

  Seeing is believing; is nonthinking; is wrongdoing.

  or (in this case)

  Not seeing is believing; is nonthinking; is wrongdoing.

N.B.
  Editors should (must) mark empty space at the end of finished lines (in red).

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
src/devices/grodvi/dvi.cpp         |  4 +--
src/devices/grohtml/grohtml.am     |  2 +-
src/devices/grohtml/html-table.cpp | 14 +++++-----
src/devices/grohtml/html-text.cpp  | 12 ++++-----
src/devices/grohtml/html.h         |  2 +-
src/devices/grohtml/post-html.cpp  | 50 ++++++++++++++++++------------------
src/devices/grolbp/lbp.cpp         |  2 +-
src/devices/grolbp/lbp.h           | 52 +++++++++++++++++++-------------------
src/devices/gropdf/gropdf.pl       |  6 ++---
src/devices/gropdf/pdfmom.pl       |  8 +++---
src/devices/grops/ps.cpp           |  6 ++---
src/devices/grops/psfig.diff       | 22 ++++++++--------
src/devices/grops/psrm.cpp         |  4 +--
src/devices/xditview/ChangeLog     |  2 +-
src/devices/xditview/Dvi.c         |  2 +-
src/devices/xditview/DviP.h        |  4 +--
src/devices/xditview/device.c      | 24 +++++++++---------
src/devices/xditview/draw.c        |  2 +-
src/devices/xditview/font.c        |  4 +--
src/devices/xditview/lex.c         |  4 +--
src/devices/xditview/parse.c       |  2 +-
src/devices/xditview/xditview.am   |  4 +--
src/devices/xditview/xditview.c    | 12 ++++-----
src/include/color.h                |  2 +-
src/include/cset.h                 |  2 +-
src/include/font.h                 | 14 +++++-----
src/include/printer.h              |  4 +--
src/include/stringclass.h          | 10 ++++----
src/libs/libbib/index.cpp          |  4 +--
src/libs/libbib/linear.cpp         |  2 +-
src/libs/libbib/search.cpp         |  2 +-
src/libs/libdriver/printer.cpp     |  4 +--
src/libs/libgroff/errarg.cpp       |  4 +--
src/libs/libgroff/error.cpp        | 28 ++++++++++----------
src/libs/libgroff/font.cpp         | 10 ++++----
src/libs/libgroff/geometry.cpp     |  4 +--
src/libs/libgroff/glyphuni.cpp     |  2 +-
src/libs/libgroff/hypot.cpp        |  2 +-
src/libs/libgroff/ptable.cpp       |  6 ++---
src/libs/libgroff/quotearg.c       |  8 +++---
src/libs/libgroff/spawnvp.c        |  4 +--
src/libs/libgroff/string.cpp       |  2 +-
src/libs/libgroff/strtol.c         |  4 +--
src/libs/libgroff/symbol.cpp       | 12 ++++-----
src/libs/libxutil/XFontName.c      |  2 +-
src/libs/snprintf/snprintf.c       |  2 +-
src/preproc/eqn/box.cpp            |  4 +--
src/preproc/eqn/delim.cpp          | 10 ++++----
src/preproc/eqn/lex.cpp            |  6 ++---
src/preproc/eqn/list.cpp           |  4 +--
src/preproc/eqn/neqn.sh            |  6 ++---
src/preproc/eqn/other.cpp          |  6 ++---
src/preproc/eqn/over.cpp           |  2 +-
src/preproc/eqn/sqrt.cpp           |  2 +-
src/preproc/eqn/text.cpp           | 10 ++++----
src/preproc/grn/gprint.h           |  2 +-
src/preproc/grn/hdb.cpp            |  2 +-
src/preproc/grn/hgraph.cpp         |  6 ++---
src/preproc/grn/main.cpp           | 10 ++++----
src/preproc/html/pre-html.cpp      |  2 +-
src/preproc/html/pre-html.h        |  2 +-
src/preproc/pic/lex.cpp            | 10 ++++----
src/preproc/pic/main.cpp           |  2 +-
src/preproc/pic/object.cpp         | 14 +++++-----
src/preproc/pic/pic.h              |  2 +-
src/preproc/pic/pic.ypp            | 10 ++++----
src/preproc/pic/tex.cpp            |  6 ++---
src/preproc/pic/troff.cpp          |  2 +-
src/preproc/preconv/preconv.cpp    |  2 +-
src/preproc/refer/label.ypp        | 14 +++++-----
src/preproc/refer/ref.cpp          | 12 ++++-----
src/preproc/refer/refer.cpp        |  6 ++---
src/preproc/refer/token.cpp        |  4 +--
src/preproc/tbl/main.cpp           |  8 +++---
src/preproc/tbl/table.cpp          | 40 ++++++++++++++---------------
src/preproc/tbl/table.h            |  8 +++---
src/roff/groff/groff.am            |  4 +--
src/roff/groff/pipeline.c          |  2 +-
src/roff/troff/TODO                |  2 +-
src/roff/troff/column.cpp          |  6 ++---
src/roff/troff/dictionary.cpp      |  6 ++---
src/roff/troff/div.cpp             | 32 +++++++++++------------
src/roff/troff/env.cpp             | 18 ++++++-------
src/roff/troff/env.h               |  6 ++---
src/roff/troff/input.cpp           |  4 +--
src/roff/troff/node.cpp            |  2 +-
src/roff/troff/token.h             | 12 ++++-----
src/roff/troff/troff.am            |  2 +-
src/utils/addftinfo/addftinfo.cpp  |  4 +--
src/utils/addftinfo/guess.h        |  2 +-
src/utils/afmtodit/afmtodit.pl     |  2 +-
src/utils/indxbib/indxbib.cpp      |  8 +++---
src/utils/pfbtops/pfbtops.c        |  2 +-
src/utils/tfmtodit/tfmtodit.cpp    |  8 +++---
94 files changed, 357 insertions(+), 357 deletions(-)

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-05 gbranden Assigned toNone => gbranden
    2017-11-10 gbranden StatusNone => Wont Fix
        Open/ClosedOpen => Closed
    2017-08-18 bgarrigues Severity3 - Normal => 2 - Minor
    2017-08-03 bjarniig Attached File- => Added 0001-Remove-bloody-empty-space-at-end-of-lines.txt.gz, #41398

    Back to the top


    Powered by Savane 3.5