bugGNU Octave - Bugs: bug #51221, deconv possibly inaccurate

 
 

bug #51221: deconv possibly inaccurate

Submitter:  Marco Caliari <caliari>
Submitted:  Sun 11 Jun 2017 09:47:14 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Inaccurate Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 08 Oct 2017 04:18:38 PM UTC, comment #7: 

The original test_deconv.m script works for me now, closing as fixed.

Mike Miller <mtmiller>
Group Member
Tue 29 Aug 2017 08:24:18 PM UTC, comment #6: 

I applied the changes by hand and pushed here:

http://hg.savannah.gnu.org/hgweb/octave/rev/6cc3aafbdc41

John W. Eaton <jwe>
Group administrator
Tue 29 Aug 2017 06:59:23 PM UTC, comment #5: 

The proposed patch no longer applies after this changeset from Rik:

http://hg.savannah.gnu.org/hgweb/octave/rev/613934236291

John W. Eaton <jwe>
Group administrator
Wed 14 Jun 2017 12:55:54 PM UTC, comment #4: 

Now it works for me, too. Thanks again.

Anonymous
Wed 14 Jun 2017 11:24:09 AM UTC, comment #3: 

Sorry, try deconv2.diff instead. Your original testcase now works for me.

(file #40916)

Marco Caliari <caliari>
Group Member
Wed 14 Jun 2017 09:05:54 AM UTC, comment #2: 

Thank you very much for working on this, Marco. Did you try to run my original testcase from bug report #51148 with the patch? I am still getting an error (but I may have made a mistake when I patched the functions by hand):


>> foster2cauer_test
error: reshape: can't reshape 2x0 array to 1x2 array
error: called from
    deconv at line 71 column 7
    foster2cauer at line 29 column 14
    foster2cauer_test at line 7 column 22
>>


Anonymous
Wed 14 Jun 2017 07:04:11 AM UTC, comment #1: 

I figured out how filter works and propose the attached patch. I would like to improve the documentation of filter for people like me which do not understand the meaning of "initial state of the system" or similar. I would like to describe SI and SF in terms of "simple" (for me) linear equations. Anybody disagrees? Should I make a patch vs stable or default?

(file #40913)

Marco Caliari <caliari>
Group Member
Sun 11 Jun 2017 09:47:14 AM UTC, original submission:  

This is a spin-off of bug report #51148. It seems that either deconv or filter is inaccurate for certain input. I attach a file from which I understand that 1) deconv is inaccurate and 2) the second output of filter, which seems accurate, could be used to compute the second output of deconv (currently, it is not done). Anybody has a better idea of the connection between filter and deconv?

Marco Caliari <caliari>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #40916:  deconv2.diff added by caliari (2KiB - application/x-tex)
file #40913:  deconv.diff added by caliari (2KiB - application/x-tex)
file #40896:  test_deconv.m added by caliari (593B - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by jwe
  • -email is unavailable- added by caliari (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-10-08 mtmiller StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-08-29 jwe StatusPatch Submitted Ready For Test
    2017-08-29 jwe Carbon-Copy- Added rik
    2017-06-15 caliari StatusNone Patch Submitted
    2017-06-14 caliari Attached File- Added deconv2.diff, #40916
    2017-06-14 caliari Attached File- Added deconv.diff, #40913
    2017-06-11 caliari Attached File- Added test_deconv.m, #40896

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code