bugGNU Octave - Bugs: bug #51219, Typos in bicgstab.m cgs.m...

 
 

bug #51219: Typos in bicgstab.m cgs.m (scripts/sparse)

Submitter:  None
Submitted:  Sat 10 Jun 2017 09:20:17 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Bruno Dias Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * dev
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 07 Sep 2017 04:36:40 PM UTC, comment #7: 

I can definitely help with coding style and option parsing.  Why don't you add my handle, rik5, to the CC list when you create the new bug report.

Rik <rik5>
Group administrator
Thu 07 Sep 2017 04:25:31 PM UTC, comment #6: 

Rik,

The mathematical algorithms are reasonably correct,
they were reviewed already by Marco an myself and discussed
with others at OctConf in Geneve.

Aspects that would benefit of a review are

  • Coding style
  • Option parsing
  • Matlab compatibility


Previous versions of these functions were not really
Matlab compatible so the last part is not really crucial
as we are making an improvement in any case with that respect.

Anyway I agree that it is not correct to repurpose this
bug, we can close this report and I'll post this info elsewhere.

c.

Carlo de Falco <cdf>
Group Member
Tue 05 Sep 2017 03:46:04 PM UTC, comment #5: 

I don't feel that I have the mathematical credentials to review, but in any case, could you open a different bug report about getting your repo reviewed and merged with the development branch?  Re-purposing a bug report doesn't usually work to get the new issue resolved because the audience for the report was based on the original problem, not the new one.

Rik <rik5>
Group administrator
Tue 05 Sep 2017 05:40:14 AM UTC, comment #4: 

I am not really sure the same exact bug exists in the
new version of the functions, as in the new version
the conversion of all types of matrix inputs is handled
by a single function for all solvers:

https://bitbucket.org/cdf1/octave/src/06f7d173f2f5231c05c44b13ff0619b4f4eb9d0a/scripts/sparse/private/__alltohandles__.m?at=dorigo&fileviewer=file-view-default

And the code for this looks correct to me there.

Maybe this is a good time to make the merge?

I have been maintaining this patch in a branch named "dorigo",

I just tried the merge in my repository on bitbucket and it
goes very smoothly, changes are only made to m-files so this
should be a relatively non-invasive merge although quite big.

If someone would like to review the changes a full diff can be seen via this link:

https://bitbucket.org/cdf1/octave/branches/compare/dorigo%0Ddefault#diff

c.

Carlo de Falco <cdf>
Group Member
Tue 05 Sep 2017 04:36:15 AM UTC, comment #3: 

I fixed the typos on the development branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/6bba9e4a1e8d).  When new versions of the solvers are merged in we need to make sure that this bug isn't re-instated.

Rik <rik5>
Group administrator
Mon 28 Aug 2017 06:06:39 PM UTC, comment #2: 

The following reply was posted to the mailing list instead of here:

Yes, the same error occur when one provides a 'string' containing the name of the function handle.

John W. Eaton <jwe>
Group administrator
Mon 12 Jun 2017 09:11:14 PM UTC, comment #1: 

There a new versions of these sovers that should be merged into the main codebase sooner or later, you can find them here:

https://bitbucket.org/cdf1/octave/branch/dorigo

does the bug also apply to those versions?

c.



Carlo de Falco <cdf>
Group Member
Sat 10 Jun 2017 09:20:17 PM UTC, original submission:  

The following lines produce error 'Ax not found':
bicgstab.m:80:    A = str2func (A);
cgs.m:76:      A = str2func (A);

Proposed fix:
bicgstab.m:80:    Ax = str2func (A);
cgs.m:76:      Ax = str2func (A);

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by cdf
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by cdf (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-05 rik5 Open/ClosedOpen Closed
    2017-09-05 cdf Open/ClosedClosed Open
    2017-09-05 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2017-08-29 cdf Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code