bugGNU Octave - Bugs: bug #51057, [octave forge] video package...

 
 

bug #51057: [octave forge] video package crashes using aviinfo

Submitter:  John Donoghue <lostbard>
Submitted:  Thu 18 May 2017 01:28:11 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Segfault, Bus Error, etc.
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  * Closed
Release:  * 4.2.1 Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 01 Jun 2017 02:14:39 PM UTC, comment #4: 

works with new release of video 1.2.4 so closing as fixed

John Donoghue <lostbard>
Group Member
Fri 19 May 2017 07:52:22 PM UTC, comment #3: 

Thank you John, for debugging and fixing this issue.

I've added your patch and requested a bugfix release https://sourceforge.net/p/octave/package-releases/308/

change status to "ready for test"

Andreas Weber <andy1978>
Group Member
Fri 19 May 2017 03:55:46 PM UTC, comment #2: 

Ok so issue is actually the get_filedate. If I change the localtime call to ::localtime, it works ok.

In addition its creating a new temp buffer to strftime with that is never freed.

Since octave has functions to do the local time and strftime, I have attached a patch that changes it to do that - and it no longer crashes in windows.

(file #40737)

John Donoghue <lostbard>
Group Member
Thu 18 May 2017 01:37:06 PM UTC, comment #1: 

I tried a reinstall of the video package for forge to see if it was an issue with cross compiling the video package, however it does the same thing with the reinstalled version as well.

John Donoghue <lostbard>
Group Member
Thu 18 May 2017 01:28:11 PM UTC, original submission:  


Using the video package on a avi file in windows 10, calling


a = aviinfo('flame.avi')


crashes octave on a both an existing file and non existing file

For a source file, I did a search for test.avi in google which came up with this link: http://www.engr.colostate.edu/me/facil/dynamics/files/flame.avi


With a quick debug, with no symbols gdb reports:


(gdb) where
#0  0x6c290d70 in liboctinterp-4!_ZN5ArrayI12octave_valueE7resize2EiiRKS0_ () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#1  0x6c2907ea in liboctinterp-4!_ZN5ArrayI12octave_valueE6resizeERK10dim_vectorRKS0_ ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#2  0x6bcc465c in liboctinterp-4!_ZN17octave_value_list6appendERK12octave_value ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#3  0x66c4521a in aviinfo!_Z8FaviinfoRK17octave_value_listi ()
   from C:\Octave\OCTAVE~1.1\lib\octave\packages\video-1.2.3\i686-w64-mingw32-api-v51\aviinfo.oct
#4  0x6bc0392d in liboctinterp-4!_ZN14octave_builtin17do_multi_index_opEiRK17octave_value_listPKSt4listI13octave_lvalueSaIS4_EE () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#5  0x6bc027ff in liboctinterp-4!_ZN14octave_builtin7subsrefERKSsRKSt4listI17octave_value_listSaIS3_EEiPKS2_I13octave_lvalueSaIS8_EE () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#6  0x6c21839b in liboctinterp-4!_ZN14octave_builtin7subsrefERKSsRKSt4listI17octave_value_listSaIS3_EE ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#7  0x6bcb40de in liboctinterp-4!_ZN12octave_value7subsrefERKSsRKSt4listI17octave_value_listSaIS3_EEi ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#8  0x6bcb4194 in liboctinterp-4!_ZN12octave_value7subsrefERKSsRKSt4listI17octave_value_listSaIS3_EEiPKS2_I13octave_lvalueSaIS8_EE () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#9  0x6bd198da in liboctinterp-4!_ZN21tree_index_expression6rvalueEiPKSt4listI13octave_lvalueSaIS1_EE ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#10 0x6bd19f69 in liboctinterp-4!_ZN21tree_index_expression7rvalue1Ei () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#11 0x6bcfbc45 in liboctinterp-4!_ZN22tree_simple_assignment7rvalue1Ei () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#12 0x6bd0a4d2 in liboctinterp-4!_ZN6octave14tree_evaluator15visit_statementER14tree_statement ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#13 0x6bd09b58 in liboctinterp-4!_ZN6octave14tree_evaluator20visit_statement_listER19tree_statement_list ()
   from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#14 0x6bfc7e64 in liboctinterp-4!_ZN6octave11interpreter9main_loopEv () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#15 0x6bfc89a9 in liboctinterp-4!_ZN6octave11interpreter7executeEv () from C:\Octave\OCTAVE~1.1\bin\liboctinterp-4.dll
#16 0x62b0a56a in liboctgui-2!_ZN18octave_interpreter7executeEv () from C:\Octave\OCTAVE~1.1\bin\liboctgui-2.dll
#17 0x0270594a in ZN14QMetaCallEvent13placeMetaCallEP7QObject () from C:\Octave\OCTAVE~1.1\bin\QtCore4.dll
#18 0x0a671df8 in ?? ()
#19 0x679117da in ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent () from C:\Octave\OCTAVE~1.1\bin\QtGui4.dll
#20 0xc70fed1e in ?? ()
#21 0x03b60000 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #40737:  bug51057.patch added by lostbard (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by lostbard (Adding package maintainer)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-06-01 lostbard StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-05-19 andy1978 StatusPatch Submitted Ready For Test
    2017-05-19 lostbard Carbon-Copy- Added andy1978
    2017-05-19 lostbard Attached File- Added bug51057.patch, #40737
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code