bugGNU Octave - Bugs: bug #50797, uint8 RGB images trigger...

 
 

bug #50797: uint8 RGB images trigger conversion error

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Thu 13 Apr 2017 03:22:16 PM UTC  
 
Category: PlottingSeverity: 4 - Important
Priority: 5 - NormalItem Group: Regression
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 24 Apr 2017 01:18:39 PM UTC, comment #5:

I pushed the patch here:
http://hg.savannah.gnu.org/hgweb/octave/rev/39045e50ea45

Closing report as fixed

Pantxo Diribarne <pantxo>
Project Member
Sun 23 Apr 2017 08:10:41 PM UTC, comment #4:

The attached patch fixes the issue for me.

(file #40477)

Pantxo Diribarne <pantxo>
Project Member
Sun 23 Apr 2017 06:11:19 PM UTC, comment #3:

I don't think we want to handle this in image.m since we want the original cdata to be stored in the image object, not a converted value. I mean the following test should pass (as it does in 4.2):

Pantxo Diribarne <pantxo>
Project Member
Fri 21 Apr 2017 09:46:04 PM UTC, comment #2:

I get the same behavior reported error on the dev branch as well.

The actual error is generated in libinterp/octave-value/ov-intx.h.

Somewhere in the code we are using object.matrix_value (). The issue is probably that the code expects to see a 2-D color data matrix at that point rather than a 3-D RGB value. I'm not sure whether the conversion is expected to happen in C++ or in the m-file image.m.

Rik <rik5>
Project Administrator
Fri 14 Apr 2017 07:53:55 AM UTC, comment #1:

Confirmed with hg_id 62320e943696.

The error comes from line 198 in image.m

which has not been changed from 4.2.1 to 4.3.0+, so the
error is deeper, in graphics.cc

Avinoam Kalma <avinoam>
Project Member
Thu 13 Apr 2017 03:22:16 PM UTC, original submission:

The following code leads to an error in the current default branch while it works as expected in 4.2.x

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40477:  ndarray.patch added by pantxo (797B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by avinoam (Posted a comment)
  • -unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 24 Apr 2017 01:18:47 PM UTCpantxoOpen/ClosedOpen=>Closed
    Mon 24 Apr 2017 01:18:39 PM UTCpantxoStatusPatch Submitted=>Fixed
    Sun 23 Apr 2017 08:10:41 PM UTCpantxoAttached File-=>Added ndarray.patch, #40477
      StatusConfirmed=>Patch Submitted
    Fri 14 Apr 2017 07:53:55 AM UTCavinoamStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup1