bugGNU Octave - Bugs: bug #50783, [octave forge] (image) imlincomb...

 
 

bug #50783: [octave forge] (image) imlincomb is not compatible with Matlab

Submitted by:  Avinoam Kalma <avinoam>
Submitted on:  Tue 11 Apr 2017 04:26:55 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Avinoam Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 May 2018 05:54:49 PM UTC, comment #4:

Thank you. I have pushed it http://hg.code.sf.net/p/octave/image/rev/cf2e5a0f20c8

Carnë Draug <carandraug>
Project Member
Wed 23 May 2018 05:06:01 PM UTC, comment #3:

Here is a better changeset.
Please review

(file #44201)

Avinoam Kalma <avinoam>
Project Member
Tue 15 May 2018 09:02:26 AM UTC, comment #2:

looks fine to me. Can you just add a comment before the addition of the scalar about where it comes from? Something like 'Add scalar to total if any'.

Aside the tests you mentioned, also needs documentation update.

Carnë Draug <carandraug>
Project Member
Thu 13 Apr 2017 03:22:20 PM UTC, comment #1:

Please review the attached patch.
I will also add some test (not included yet)

(file #40393)

Avinoam Kalma <avinoam>
Project Member
Tue 11 Apr 2017 04:26:55 PM UTC, original submission:

imlincomb can have an additive scalar as the last parameter
(or one before the last, if the last one is the output class).
for example:

128 is a additive scalar, and not output class.

Avinoam Kalma <avinoam>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44201:  imlincomb.cs added by avinoam (4KiB - application/octet-stream)
file #40393:  imlincomb.diff added by avinoam (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by avinoam (Submitted the item)
  • -email is unavailable- added by avinoam
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-23 carandraug StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2018-05-23 avinoam Attached File- => Added imlincomb.cs, #44201
    2018-03-13 avinoam Carbon-Copy- => Added carandraug
        Carbon-Copy- => Added hardy
    2018-03-13 avinoam StatusNone => Patch Submitted
    2017-08-12 jwe Summaryimage package: imlincomb is not compatible with Matlab => [octave forge] (image) imlincomb is not compatible with Matlab
    2017-04-13 avinoam Attached File- => Added imlincomb.diff, #40393
    2017-04-11 avinoam Summaryimage package: imlincomb is not compatible with Maltab => image package: imlincomb is not compatible with Matlab
    2017-04-11 avinoam Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.3