bugGNU Octave - Bugs: bug #50772, implement missing functions rotx,...

 
 

bug #50772: implement missing functions rotx, roty, rotz

Submitted by:  Nicholas Jankowski <nrjank>
Submitted on:  Mon 10 Apr 2017 03:29:37 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Matlab Compatibility
Status: Patch SubmittedAssigned to: None
Originator Name: Nicholas JankowskiOpen/Closed: Closed
Release: 4.2.1Operating System: Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 14 Aug 2017 01:14:57 PM UTC, comment #8:

Since there is now a separate issue on the patch tracker that links back to this bug report and I don't think it is necessary to track the issue in two places, I'm closing this report.

John W. Eaton <jwe>
Project Administrator
Sun 13 Aug 2017 10:34:53 PM UTC, comment #7:

The patch here applies to core, so I am not sure this should be flagged as [octave-forge].

Juan Pablo Carbajal <juanpi>
Project Member
Tue 11 Apr 2017 08:26:03 PM UTC, comment #6:

patch #9310 added.

Nicholas Jankowski <nrjank>
Tue 11 Apr 2017 02:24:38 PM UTC, comment #5:

ok, will generate that patch and post it over on the patch tracker then post a link here.

Nicholas Jankowski <nrjank>
Tue 11 Apr 2017 02:05:29 PM UTC, comment #4:

Nicholas,

I suggest you create the patch for core geometry package and upload it in a separate patch report. Let see if somebody can add it.
I can help improving the functions once you put them up.

Juan Pablo Carbajal <juanpi>
Project Member
Mon 10 Apr 2017 04:47:32 PM UTC, comment #3:

question also posed to maintainers list, but it was suggested that this may be appropriate to put in octave core. suggestions appreciated.

Nicholas Jankowski <nrjank>
Mon 10 Apr 2017 03:49:00 AM UTC, comment #2:

patch v2 attached. one of the functions had a broken docstring and a typo in a test

(file #40345)

Nicholas Jankowski <nrjank>
Mon 10 Apr 2017 03:32:48 AM UTC, comment #1:

missing, not mission. :)

patch attached that puts files in inst/geom3d folder.

(file #40344)

Nicholas Jankowski <nrjank>
Mon 10 Apr 2017 03:29:37 AM UTC, original submission:

Came up on the help list that rotx, roty, and rotz vector rotation functions were mission. Attached are simple matlab compatible implementations for the geometry package. Functions are very close to some existing geometry functions, these were made to sit in the same location. will attach patch after bug number generated.

Nicholas Jankowski <nrjank>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40345:  add_rotxyz_v2.diff added by nrjank (8KiB - application/octet-stream)
file #40344:  add_rotxyz.diff added by nrjank (8KiB - application/octet-stream - patch)
file #40341:  rotx.m added by nrjank (2KiB - application/octet-stream)
file #40342:  rotz.m added by nrjank (2KiB - application/octet-stream)
file #40343:  roty.m added by nrjank (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by juanpi (Posted a comment)
  • -unavailable- added by nrjank (Submitted the item)
  • -unavailable- added by nrjank
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Aug 2017 01:14:57 PM UTCjweCategoryOctave Forge Package=>Octave Function
      StatusNone=>Patch Submitted
      Open/ClosedOpen=>Closed
      Summary[octave forge] (geometry) implement missing functions rotx, roty, rotz=>implement missing functions rotx, roty, rotz
    Sat 12 Aug 2017 07:02:33 PM UTCjweSummarygeometry: implement missing functions rotx, roty, rotz=>[octave forge] (geometry) implement missing functions rotx, roty, rotz
    Mon 10 Apr 2017 03:49:00 AM UTCnrjankAttached File-=>Added add_rotxyz_v2.diff, #40345
    Mon 10 Apr 2017 03:32:48 AM UTCnrjankAttached File-=>Added add_rotxyz.diff, #40344
    Mon 10 Apr 2017 03:29:37 AM UTCnrjankAttached File-=>Added rotx.m, #40341
      Attached File-=>Added rotz.m, #40342
      Attached File-=>Added roty.m, #40343
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1