bugGNU Octave - Bugs: bug #49896, dicom package needs updates to...

 
 

bug #49896: dicom package needs updates to work with Octave 4.x and GDCM 2.6

Submitter:  None
Submitted:  Tue 20 Dec 2016 06:13:16 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Installation Failure
Status:  Fixed Assigned to:  lostbard
Originator Name:  Todd Jensen Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 4.0.3
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 23 Feb 2017 04:44:12 PM UTC, comment #5: 

Closing as fixed  - dicom 0.2.0 has been released

John Donoghue <lostbard>
Group Member
Wed 01 Feb 2017 05:59:25 PM UTC, comment #4: 

Pushed detection of Darwin OS for the framework

https://sourceforge.net/p/octave/dicom/ci/1178b3204eae6e5996679ca94fcc4f15499787a3/


If anyone can test it works?

John Donoghue <lostbard>
Group Member
Thu 22 Dec 2016 01:32:58 PM UTC, comment #3: 

A patch may be needed for the mac specific stuff

John Donoghue <lostbard>
Group Member
Wed 21 Dec 2016 10:53:29 PM UTC, comment #2: 

The patch you sent seems to fix multiple issues so it's hard to know for sure if it fixes all the issues.  Can you do the following:


hg clone http://hg.code.sf.net/p/octave/dicom
cd dicom
make dist


And check if the generated tarball 'target/dicom-0.1.1.tar.gz' has all the fixes you need?

Carnë Draug <carandraug>
Group Member
Tue 20 Dec 2016 09:04:52 PM UTC, comment #1: 

Hi,

I believe this has been fixed in bug #44624 and bug #44430, however a new dicom package has not been released yet.


John Donoghue <lostbard>
Group Member
Tue 20 Dec 2016 06:13:16 PM UTC, original submission:  

I have created a patch that allows the dicom package to be installed on GNU Octave 4.0.3 on a system that has GDCM 2.6. The patch file is attached.

NOTE1: I had to add a check for Mac OS X in the Makefile to add a framework used by GDCM.

NOTE2: The patch could be made less dependent upon GDCM version if the GDCM version in the include paths could be removed. I did not explore how to do that.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39288:  dicom-0.1.1-patch.txt.gz added by None (3KiB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-23 lostbard StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-02-01 lostbard StatusNone Ready For Test
        Assigned toNone lostbard
    2016-12-20 None Attached File- Added dicom-0.1.1-patch.txt.gz, #39288

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code