bugQuilt - Bugs: bug #49693, Rename after forced push leaves...

 
 

bug #49693: Rename after forced push leaves dangling marker

Submitter:  Jean Delvare <khali>
Submitted:  Thu 24 Nov 2016 09:50:55 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 24 Nov 2016 09:53:11 AM UTC, comment #1: 

I guess this should be done in function rename_in_db(), to make sure we cover all present and future situations.

Jean Delvare <khali>
Group administrator
Thu 24 Nov 2016 09:50:55 AM UTC, original submission:  

If you force-push a patch that does not apply cleanly, quilt tells you it needs to be refreshed, and creates a marker to remember this under .pc/. If you rename the patch before refreshing it, quilt will forget about this. So it will let you continue even if the patch was not refreshed, and it will never delete the marker.

We need to rename the marker when a patch which needs to be refreshed is renamed. Same is probably needed for the fork command as well, as it's essentially a rename with a backup.

The test suite should cover this scenario.

Jean Delvare <khali>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by khali (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code