bugGNU Octave - Bugs: bug #48580, Install fails after configuring...

 
 

bug #48580: Install fails after configuring with --disable-docs

Submitter:  Robert Jenssen <morgawr>
Submitted:  Thu 21 Jul 2016 09:18:14 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Robert Jenssen Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 22 Jul 2016 04:47:51 PM UTC, comment #6: 

This works for me now, so I'm closing the report.  If I still missed something, comment to reopen.  Thanks.

John W. Eaton <jwe>
Group administrator
Fri 22 Jul 2016 02:30:54 PM UTC, comment #5: 

Thanks, I checked in this additional change:

  http://hg.savannah.gnu.org/hgweb/octave/rev/623b556e9d45

John W. Eaton <jwe>
Group administrator
Fri 22 Jul 2016 01:43:42 PM UTC, comment #4: 

I updated to 187b6727c75e and ran:

./bootstrap && cd ../build && ../octave/configure --prefix=/usr/local/octave-disable-docs --disable-docs --disable-java --without-fltk --without-qt  && make V=1 -j 6 && make install


Installed without error. Then:

# /usr/local/octave-disable-docs/bin/octave-cli -q
octave:1> help inv
error: unable to open /usr/local/octave-disable-docs/share/octave/4.1.0+/etc/macros.texi for reading
error: called from
    __makeinfo__ at line 101 column 5
    help at line 102 column 22
octave:1>


Robert Jenssen <morgawr>
Fri 22 Jul 2016 01:06:20 PM UTC, comment #3: 

The --disable-docs option shouldn't disable creation and installation of the DOCSTRINGS files.  That option is really intended to disable things that require TeX.  Maybe it should be renamed, but that's not a high priority for me.

The problem should be fixed by this patch:

  http://hg.savannah.gnu.org/hgweb/octave/rev/187b6727c75e

It also fixes a problem with cross compiling VPATH builds from tarball distributions.  Let me know if there are still problems as this needs to be fixed before the release.

John W. Eaton <jwe>
Group administrator
Fri 22 Jul 2016 05:09:27 AM UTC, comment #2: 

Perhaps:

diff -r bbaeaed0c584 libinterp/module.mk
--- a/libinterp/module.mk        Wed Jul 20 16:33:58 2016 -0400
+++ b/libinterp/module.mk        Fri Jul 22 12:13:42 2016 +1000
@@ -323,7 +323,7 @@
 endif
 .PHONY: install-oct uninstall-oct

-install-built-in-docstrings:
+install-built-in-docstrings: libinterp/DOCSTRINGS
         $(MKDIR_P) $(DESTDIR)$(octetcdir)
         f=libinterp/DOCSTRINGS; \
           if test -f $$f; then d=; else d="$(srcdir)/"; fi; \


Robert Jenssen <morgawr>
Thu 21 Jul 2016 04:29:10 PM UTC, comment #1: 

Thank you for your bug report and patch. The --disable-docs switch is broadly scoped and a little vague as to what it disables. I remember dicussing --disable-docs with jwe recently. I can't remember whether his opinion was that the built-in-docstrings file should be installed even with --disable-docs or not. Specifically what tools or build steps is --disable-docs intended to avoid?

Mike Miller <mtmiller>
Group Member
Thu 21 Jul 2016 09:18:14 AM UTC, original submission:  

I tried to build with --disable-docs:

../octave/configure --prefix=/usr/local/octave-disable-docs --disable-docs
make -j 6 && make install


The build fails at "make install" with:

/usr/bin/mkdir -p /usr/local/octave-disable-docs/share/octave/4.1.0+/etc
f=libinterp/DOCSTRINGS; \
  if test -f $f; then d=; else d="../octave/"; fi; \
  /usr/bin/install -c -m 644 "$d$f" /usr/local/octave-disable-docs/share/octave/4.1.0+/etc/built-in-docstrings
/usr/bin/install: cannot stat '../octave/libinterp/DOCSTRINGS': No such file or directory
Makefile:27109: recipe for target 'install-built-in-docstrings' failed
make[4]: *** [install-built-in-docstrings] Error 1


The following patch fixes the problem:

diff -r bbaeaed0c584 libinterp/module.mk
--- a/libinterp/module.mk        Wed Jul 20 16:33:58 2016 -0400
+++ b/libinterp/module.mk        Thu Jul 21 18:53:26 2016 +1000
@@ -323,11 +323,16 @@
 endif
 .PHONY: install-oct uninstall-oct

+if AMCOND_BUILD_DOCS
 install-built-in-docstrings:
         $(MKDIR_P) $(DESTDIR)$(octetcdir)
         f=libinterp/DOCSTRINGS; \
           if test -f $$f; then d=; else d="$(srcdir)/"; fi; \
           $(INSTALL_DATA) "$$d$$f" $(DESTDIR)$(octetcdir)/built-in-docstrings
+else
+install-built-in-docstrings:
+
+endif
 .PHONY: install-built-in-docstrings

 uninstall-built-in-docstrings:


Robert Jenssen <morgawr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by mtmiller
  • -email is unavailable- added by morgawr (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-22 jwe StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2016-07-22 jwe StatusPatch Submitted Ready For Test
    2016-07-21 mtmiller StatusNone Patch Submitted
        Carbon-Copy- Added jwe

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code