bugGNU Octave - Bugs: bug #48430, scripts/DOCSTRINGS nearly always...

 
 

bug #48430: scripts/DOCSTRINGS nearly always rebuilt causing full doc build

Submitter:  Rik <rik5>
Submitted:  Thu 07 Jul 2016 04:38:49 AM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 11 Jul 2016 12:07:57 AM UTC, comment #6: 

Seems to work for me.  Closing report.

Rik <rik5>
Group administrator
Fri 08 Jul 2016 06:30:47 PM UTC, comment #5: 

There were still some problems with DOCSTRINGS existing in the source directory, but rules and dependencies indicating that the files needed to be rebuilt.

I pushed a change that now builds DOCSTRINGS under the build directory, but respects and uses the files if they exist in the source directory and are up to date with respect to their input files.

http://hg.savannah.gnu.org/hgweb/octave/rev/df50d42d4b1b

I hope that this doesn't break anything else, this is a particularly complex part of the build system where a lot of things come together, and it's a file that we build when we build out of hg, but don't need to build from a source release, etc.

You can now delete $(srcdir)/libinterp/DOCSTRINGS and $(srcdir)/scripts/DOCSTRINGS if you were doing out-of-tree builds (but shouldn't be a problem if you leave the stale files there either).

Mike Miller <mtmiller>
Group Member
Thu 07 Jul 2016 07:11:01 PM UTC, comment #4: 

There was some problem where the documentation was not being built reliably which required executing make twice in a row.  The original change may have been to deal with that.

Let's see how things build now.

Rik <rik5>
Group administrator
Thu 07 Jul 2016 06:44:19 PM UTC, comment #3: 

I'm not sure whether I was trying to fix a problem (if I was, I should have documented it, eh?) or if it was unintentional.  So I checked in the following change:

  http://hg.savannah.gnu.org/hgweb/octave/rev/1340feab13a8

John W. Eaton <jwe>
Group administrator
Thu 07 Jul 2016 06:27:51 PM UTC, comment #2: 

Both libinterp/DOCSTRINGS and scripts/DOCSTRINGS are rebuilt every time now, instead of only if the contents change, and this forces a full rebuild of the documentation.

Either


$ touch ../libinterp/corefcn/data.cc
$ make all


or


$ touch ../scripts/time/now.m
$ make


cause the corresponding ../libinterp/DOCSTRINGS or ../scripts/DOCSTRINGS to be rebuilt, without move-if-change, and so on.

The relevant changes on the default branch are

http://hg.savannah.gnu.org/hgweb/octave/rev/627f582edbe3#l2.25
http://hg.savannah.gnu.org/hgweb/octave/rev/112b20240c87#l131.167

So this was tied to the move to build doc strings from the true source files, rather than intermediate preprocessed files, but maybe an unintentional side effect.

Mike Miller <mtmiller>
Group Member
Thu 07 Jul 2016 08:58:51 AM UTC, comment #1: 

I find that the texi files are also often rebuilt unnecessarily, causing a full doc build.  I assumed that it was some messing I did to work around the texinfo.tex bug, but perhaps it is related to this.

Lachlan Andrew <lachlan>
Thu 07 Jul 2016 04:38:49 AM UTC, original submission:  

While editing m-files in the scripts directory, I find that the file scripts/DOCSTRINGS is nearly always rebuilt which causes a full documentation rebuild.

I copied DOCSTRINGS to a temporary file and compared the temporary file to the copy generated by the build process and they are the same.  Apparently the move-if-change rule is not being used for this file.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by lachlan (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-11 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2016-07-07 lachlan StatusConfirmed Ready For Test
    2016-07-07 mtmiller StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code