bugGNU Octave - Bugs: bug #47288, interval package: wont install on...

 
 

bug #47288: interval package: wont install on 4.1.0+ dev octave

Submitter:  John Donoghue <lostbard>
Submitted:  Sat 27 Feb 2016 06:31:29 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  lostbard Open/Closed:  * Closed
Release:  * 4.2.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 18 Jan 2017 06:06:10 PM UTC, comment #9: 

Done

Avinoam Kalma <avinoam>
Group Member
Wed 18 Jan 2017 06:03:37 PM UTC, comment #8: 

Yes, please mark it as fixed.

The original error has been fixed in this revision:
https://sourceforge.net/p/octave/interval/ci/2834d14c761a7c20f2a9ce810317d942aebc0462/

and has been released as part of version 1.5.0, see https://octave.sourceforge.io/interval/NEWS.html

The other error (M_PI / c++11) is a separate issue and probably has already been fixed elsewhere.

Oliver Heimlich <oheim>
Wed 18 Jan 2017 05:14:09 PM UTC, comment #7: 

Should I close this report as fixed?

Avinoam Kalma <avinoam>
Group Member
Mon 28 Nov 2016 01:58:50 PM UTC, comment #6: 

I think my comment can be ignored now - it appears to work on both the w32 and w64 installer

I may have been playing around with flags for other packages and had set CPPFLAGS=c++11  - which does make it fail with error below.


John Donoghue <lostbard>
Group Member
Mon 28 Nov 2016 01:27:59 PM UTC, comment #5: 

I cannot reproduce the installation error in Windows with Octave 4.2.0.  Do you use the official installer for Octave?

Oliver Heimlich <oheim>
Thu 24 Nov 2016 03:06:06 PM UTC, comment #4: 

Still fails in windows with octave 4.2.0, however now because M_PI is not defined.

(interval 2.0.0)



C:/Octave/Octave-4.2.0/bin/mkoctfile-4.2.0.exe --verbose  -o mpfr_function_d.oct -lmpfr  mpfr_function_d.cc
g++ -std=gnu++11 -c -std=c++11  -IC:\Octave\Octave-4.2.0\include\octave-4.2.0\octave\.. -IC:\Octave\Octave-4.2.0\include\oc
tave-4.2.0\octave -IC:\Octave\Octave-4.2.0\include  -pthread -fopenmp -mieee-fp -g -O2    mpfr_function_d.cc -o mpfr_functi
on_d.o
In file included from C:\Octave\Octave-4.2.0\include\octave-4.2.0\octave\../octave/lo-utils.h:36:0,
C:\Octave\Octave-4.2.0\include\octave-4.2.0\octave\../octave/oct-cmplx.h:55:36: error: 'M_PI' was not declared in this scop
e
         if (ay == static_cast<T> (-M_PI))



Similar issue seen in level-set reported in bug #49294

John Donoghue <lostbard>
Group Member
Fri 04 Mar 2016 07:01:26 AM UTC, comment #3: 

Thanks, I will use your patch.

Oliver Heimlich <oheim>
Thu 03 Mar 2016 05:04:49 PM UTC, comment #2: 

Actually the OpenMP standard specifies that the _OPENMP macro is defined if OpenMP is active. So you should be able to rely on that and do something like the attached instead.



(file #36536)

Mike Miller <mtmiller>
Group Member
Wed 02 Mar 2016 11:30:12 PM UTC, comment #1: 

Could a C++ expert please review the attached patch?

I have removed the #include directive on oct-openmp.h in the interval package and use plain #pragma directives. My understanding is that these directives will be ignored if OpenMP is not present or not enabled.

Additionally, I have added a -Wno-unknown-pragmas switch to the compiler. The absence of OpenMP pragmas should be no problem since it will simply disable parallel execution.

(file #36531)

Oliver Heimlich <oheim>
Sat 27 Feb 2016 06:31:29 PM UTC, original submission:  

WIth recent changes to dev octave (removed oct-openmp.h), interval will no longer compile:


>> pkg install -forge interval
mpfr_matrix_mul_d.cc:19:31: fatal error: octave/oct-openmp.h: No such file or directory
 #include <octave/oct-openmp.h>
                               ^
compilation terminated.
mpfr_matrix_sqr_d.cc:19:31: fatal error: octave/oct-openmp.h: No such file or directory
 #include <octave/oct-openmp.h>
                               ^
compilation terminated.


John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36536:  bug-47288-2.diff added by mtmiller (3KiB - text/x-diff)
file #36531:  bug-47288.diff added by oheim (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by oheim (Updated the item)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-18 avinoam StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2016-11-24 lostbard Releasedev 4.2.0
    2016-03-03 mtmiller Attached File- Added bug-47288-2.diff, #36536
        StatusNone Patch Submitted
    2016-03-02 oheim Attached File- Added bug-47288.diff, #36531

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code