bugGnash - The GNU Flash player - Bugs: bug #47055, Gnash testsuite should not produce...

 
 

bug #47055: Gnash testsuite should not produce compressed SWF5 file

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Wed 03 Feb 2016 02:25:22 PM UTC  
 
Category: testsuiteSeverity: 3 - Normal
Release: masterStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 08 Feb 2016 09:55:28 AM UTC, comment #6:

Thanks for confirming

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 07 Feb 2016 01:23:41 PM UTC, comment #5:

No, that should be it; in current git version, no more compressed SWF
version <= 5 are generated from testsuite anymore.

The SWF5 test issue unrelated to compression will be discussed in bug #47054.
This bug could now be marked as fixed, thank you.

Gnash testsuite: 0.8.11dev (git 435d3e9 6-Feb-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>
Sat 06 Feb 2016 11:58:38 AM UTC, comment #4:

The 3 left-over are fixed with commit b628b4f9d6a738ed8c58f683bd45ebb1c9decdb8
anything else ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 04 Feb 2016 09:16:03 AM UTC, comment #3:

With current version of testsuite, there seems to be no compressed SWF with
version <= 5 in `actionscript.all` section anymore.

But still, there are more compressed SWF version <= 5 in other section:

Side note: The affected SWF5 test mentioned in original submission is now
able to be loaded by Flash Player 5, though the test run didn't complete.
I'll file this as a separate issue.

Gnash testsuite: 0.8.11dev (git 02ec1e6 3-Feb-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>
Wed 03 Feb 2016 03:34:23 PM UTC, comment #2:

I've also pushed a change to libming so it at least warns in those cases:
https://github.com/libming/libming/commit/a71e3e562c7ddf25ac9ba3bda64d75b1252238f9

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 03 Feb 2016 03:06:05 PM UTC, comment #1:

See commit:02ec1e61bf5b08a5db29472c268a2e448ac8772a

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 03 Feb 2016 02:25:22 PM UTC, original submission:

This is a spin-off from bug #47054 (`getvariable.as` testsuite failure).

I found that when I tried to open `getvariable-v5.swf` test from
Gnash testsuite on a real Flash Player 5, it wouldn't load.

When right-clicked on the screen, context menu shown grayed-out
"Movie not loaded..." status.

Root cause of the issue appeared when I tried to use `file` command
to check if test SWFs were corrupted:

According to Adobe's specification, SWF version 5 does not support compression;
so it simply won't load. Later version of Flash Player e.g. v7, v9, and v11
decompressed the file properly as they have compression support.

Gnash testsuite: 0.8.11dev (git e705394 29-Jan-2016)
Flash Player: 5.0 r41 (5.0.41.0) NPAPI binary
Browser: Mozilla Filefox 11.0
System: Microsoft Windows XP Professional SP3

P.S. For the record, each SWF version have compression support as follows:

  • Uncompressed SWF (file's magic string "FWS") is supported since forever.
  • Zlib compression scheme (file's magic string "CWS") is supported since SWF version 6.
  • LZMA compression scheme (file's magic string "ZWS") is supported since SWF version 13.
Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 08 Feb 2016 09:55:28 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 03 Feb 2016 03:06:38 PM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1