bugGNU Octave - Bugs: bug #46833, video: output of avifile function...

 
 

bug #46833: video: output of avifile function shows warning

Submitter:  John Donoghue <lostbard>
Submitted:  Wed 06 Jan 2016 08:51:31 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 10 Jan 2016 10:30:10 AM UTC, comment #6: 

@JohnD.: I've changed malloc -> av_malloc in cset ba08d02e63de.
Thank you very much for your help.

Andreas Weber <andy1978>
Group Member
Thu 07 Jan 2016 09:37:13 PM UTC, comment #5: 

This patch based on the released video package works for me (no crash running test script)


(file #35942)

John Donoghue <lostbard>
Group Member
Thu 07 Jan 2016 01:26:15 AM UTC, comment #4: 

Pushed mxe-octave video package. After building and installing mxe-octave, the video package should already be installed, ready to load.

John Donoghue <lostbard>
Group Member
Wed 06 Jan 2016 10:22:37 PM UTC, comment #3: 

I think older octave versions had the const function.

I save seen the ML, I believe at one time I saw that, but haven't recently (I believe since the new video package came out)

I am going to push a change up to mxe to include video as one of the packages so it gets all of ffmpeg libs etc built as part of the installer.

John Donoghue <lostbard>
Group Member
Wed 06 Jan 2016 10:01:52 PM UTC, comment #2: 

Hi John. Instead of applying your patch I just removed the const qualifier with cset a9bb1c1fb5d1. I don't see a reason why const was used here.

Thank you.

btw, Don't you see the segfault as described in http://octave.1599824.n4.nabble.com/Request-help-debugging-octave-video-in-mxe-octave-td4674269.html ?

Andreas Weber <andy1978>
Group Member
Wed 06 Jan 2016 08:55:39 PM UTC, comment #1: 

Ptahc attached

(file #35938)

John Donoghue <lostbard>
Group Member
Wed 06 Jan 2016 08:51:31 PM UTC, original submission:  

On Windows, but is probably the same on Linux.

Running mxe-octave 4.0.0, video 1.2.1:


>> a = avifile('mytest.avi')
a =

error: octave_base_value::print (): wrong type argument 'avifile'




Adding a non const print function to the AviFile class fixes it.

Patch coming in a few minutes.

John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35942:  of-video-1-fixes.patch added by lostbard (2KiB - application/octet-stream)
file #35938:  videfix.patch added by lostbard (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-01-07 lostbard Attached File- Added of-video-1-fixes.patch, #35942
    2016-01-06 andy1978 StatusNone Fixed
        Open/ClosedOpen Closed
    2016-01-06 lostbard Attached File- Added videfix.patch, #35938

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code