bugfindutils - Bugs: bug #46714, make oldfind optional

 
 

bug #46714: make oldfind optional

Submitter:  Mike Frysinger <vapier>
Submitted:  Fri 18 Dec 2015 05:10:59 PM UTC
   
 
Category:  find Severity:  2 - Minor
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  Open/Closed:  Closed
Release:  4.3.0 Fixed Release:  4.5.18
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 28 Dec 2015 11:07:35 AM UTC, comment #5: 

Thanks for your help.

James Youngman <jay>
Group administrator
Mon 28 Dec 2015 11:07:13 AM UTC, comment #4: 

I applied the attached patch also.

(file #35873)

James Youngman <jay>
Group administrator
Sun 27 Dec 2015 09:45:23 PM UTC, comment #3: 

few notes:
 - find/Makefile.am: using noinst_PROGRAMS means it'll still be compiled/linked.  if you used check_PROGRAMS instead, that'd only happen if you did `make oldfind` or `make check`.
 - whitespace in find/Makefile.am with the new line is off
 - configure.ac: i would just delete the fts configure option entirely.  i don't think keeping --with-fts is useful.  if you delete it, configure will still warn about the flag being unknown for devs to see.
 - configure.ac: whitespace is off w/new no case -- it's mixing tabs w/spaces.
 - do you still need the WITH_FTS make conditional ?

Mike Frysinger <vapier>
Sun 27 Dec 2015 09:23:36 PM UTC, comment #2: 

I made some additional minor changes, notably to unix.exp.

James Youngman <jay>
Group administrator
Sun 27 Dec 2015 08:46:33 PM UTC, comment #1: 

The attached patches (which I am about to apply) do, I think, most of what you are asking:

1. configure's --with-fts option becomes a no-op.
2. Rejects configure --without-fts.
3. Retains oldfind as a test utility only (for A/B testing)
4. Renames find.c to oldfind.c for clarity

The only thing I think you asked for which these patches don't do is skip testing oldfind.

(file #35869, file #35870)

James Youngman <jay>
Group administrator
Fri 18 Dec 2015 05:10:59 PM UTC, original submission:  

we've had the fts logic available for over 10 years now.  can we get a configure option to disable building/testing/installing of the oldfind ?

Mike Frysinger <vapier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Updated the item)
  • -email is unavailable- added by vapier (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-28 jay Attached File- Added 0001-Apply-some-improvements-suggested-by-Mike-Frysinger.patch, #35873
    2015-12-27 jay StatusNone Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.5.18
    2015-12-27 jay Release4.5.17 4.3.0
    2015-12-27 jay Attached File- Added 0001-Remove-support-for-installing-oldfind.patch, #35869
        Attached File- Added 0002-Rename-find-find.c-to-find-oldfind.c.patch, #35870
        Severity3 - Normal 2 - Minor
        Assigned toNone jay
        ReleaseNone 4.5.17

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code