bugGNU Octave - Bugs: bug #46444, [octave forge] (signal) buttord,...

 
 

bug #46444: [octave forge] (signal) buttord, cheb1ord, cheb2ord : different errors

Submitted by:  Charles Praplan <charprap>
Submitted on:  Sat 14 Nov 2015 01:49:29 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  Mike Miller <mtmiller>
Originator Name:  Charles Praplan Open/Closed:  Closed
Release:  other Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 30 Apr 2018 08:28:25 PM UTC, comment #8: 

This work has now been merged into the signal package, thank you very much for your contribution and your help getting the code and demos and tests ready for inclusion.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 12 Apr 2018 12:42:29 PM UTC, comment #7: 

Forget files 43894 to 43896 (wrong arguments for validate_filter_bands(..) ).
Use latest files.
Sorry!

(file #43897, file #43898, file #43899)

Charles Praplan <charprap>
Thu 12 Apr 2018 12:27:47 PM UTC, comment #6: 

Here are the buttord, cheb1ord and cheb2ord function.

I hope this can help you integrating them into next version.

(file #43894, file #43895, file #43896)

Charles Praplan <charprap>
Tue 10 Apr 2018 09:47:49 PM UTC, comment #5: 

The Octave compatible demos for the ellipord function have been attached to bug #45811, as adapted from the test scripts you provided us.

In short, the work involves getting rid of for loops, do not invoke 'clear all', 'close all', or 'figure', copying the for loop body to separate %!demo blocks, with fpass or fstop varying in each %!demo block as needed.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Wed 04 Apr 2018 04:43:41 PM UTC, comment #4: 

Yes I can spend some time on this in the next weeks (of course not full time).
For the %!demo blocks, the example of the ellipord function (when you will be so far with it) will for sure help me understand your needs. Please send it then to me.

Charles Praplan <charprap>
Tue 03 Apr 2018 09:41:12 PM UTC, comment #3: 

As with bug #45811, thank you very much for your work on this contribution, this is an excellent functional improvement, and the demonstration scripts are very helpful as well. I am sorry that it has taken a couple of years for me to get around to reviewing it properly.

I will be spending some time on integrating your ellipord changes from bug #45811. If you are willing to spend some more time on this, it would be helpful to reduce the amount of integration work I will have to do on this bug report. Some of the changes that are necessary include

  • turn the demonstration scripts into proper %!demo blocks for use with the 'demo' function
  • each function now has one failing test, update the test suite for the corresponding changes in the allowed arguments

In general, the easiest kind of submission like this would be a 'diff -u' patch of each function file, with tests and demos integrated into the function files to work with Octave's 'test' and 'demo' commands.

If you don't want to spend any more time on this, then I can do the integration work myself, as I have already started doing on bug #45811, but it may take some time.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 22 Dec 2015 05:46:00 PM UTC, comment #2: 

Thanks for your contribution to the signal package functions. I am definitely interested in taking a look at these changes.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sat 05 Dec 2015 08:35:57 AM UTC, comment #1: 

Hi,

I made a few corrections (and improvements) in the comments (and only in the comments) of the m-files I posted some time ago.

I attached the new diff files (diff from the official version of signal package 1.3.2): (file #35643 to 35645).

Please, let me know if this contribution is of interest.
Charles

Charles Praplan <charprap>
Sat 14 Nov 2015 01:49:29 PM UTC, original submission:  

The functions buttord, cheb1ord, cheb2ord had different problems
and missing functionalities on which I worked to propose
here corrections. As the corrections are partially the same for
all 3 function, I decided to post only one error report.

I append a zip file with all the necessary files and testcases,
and the diff files.

Below the detailed description of all corrections, each time with
the corresponding test case.

buttord:
=======

1) Error corrected

     The known problem of overdesigning bandpass and bandreject filters
     (displayed as warning by the function) has been solved.

     Test cases: buttord_test_dig_BP.m
                 buttord_test_dig_notch.m

2)Improvements

2.1) Analog filters are now supported as in Matlab.
     (this includes a new 'validate_filter_bandss.m'
     function for analog filters that I already submitted
     in the case of the ellipord function).

     Test cases: buttord_test_ana_LP.m
                 buttord_test_ana_HP.m
                 buttord_test_ana_BP.m
                 buttord_test_ana_notch.m

2.2) New output argument allows to make the filter caracteristic
     touch the passband or stopband corner.

     Test cases: buttord_test_ana_LP.m
                 buttord_test_ana_HP.m
                 buttord_test_ana_BP.m
                 buttord_test_ana_notch.m

                 buttord_test_dig_LP.m
                 buttord_test_dig_HP.m
                 buttord_test_dig_BP.m
                 buttord_test_dig_notch.m

cheb1ord and cheb2ord:
=====================

1) Error corrected

     Solved problem in cheb2ord for band pass filter:
     filter did not satisfy requirements in case of
     NOT symmetrical requirements

     Test cases: buttord_test_dig_BP.m  (fig 5 to 8)

2) Missing functionaly

     Notch filters are now supported

     Test cases: cheb12ord_test_ana_notch.m
                 cheb12ord_test_dig_notch.m

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

                 cheb12ord_test_dig_LP.m
                 cheb12ord_test_dig_HP.m
                 cheb12ord_test_dig_BP.m
                 cheb12ord_test_dig_notch.m

3)Improvements

3.1) Analog filters are now supported as in Matlab.
     (this includes a new 'validate_filter_bandss.m'
     function for analog filters that I already submitted
     in the case of the ellipord function).

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

3.2) New output argument allowing to make the filter caracteristic
     touch the passband or stopband corner.

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

                 cheb12ord_test_dig_LP.m
                 cheb12ord_test_dig_HP.m
                 cheb12ord_test_dig_BP.m
                 cheb12ord_test_dig_notch.m

Charles Praplan <charprap>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43897:  buttord.m added by charprap (39KiB - application/octet-stream)
file #43898:  cheb1ord.m added by charprap (36KiB - application/octet-stream)
file #43899:  cheb2ord.m added by charprap (36KiB - application/octet-stream)
file #43894:  buttord.m added by charprap (39KiB - application/octet-stream)
file #43895:  cheb1ord.m added by charprap (36KiB - application/octet-stream)
file #43896:  cheb2ord.m added by charprap (36KiB - application/octet-stream)
file #35643:  buttord.diff added by charprap (7KiB - application/octet-stream - Comments improved.)
file #35644:  cheb1ord.diff added by charprap (6KiB - application/octet-stream - Comments improved.)
file #35645:  cheb2ord.diff added by charprap (7KiB - application/octet-stream - Comments improved.)
file #35457:  buttord_cheb1ord_cheb2ord.zip added by charprap (26KiB - application/x-zip)
file #35458:  buttord.diff added by charprap (7KiB - application/octet-stream)
file #35459:  cheb1ord.diff added by charprap (6KiB - application/octet-stream)
file #35460:  cheb2ord.diff added by charprap (6KiB - application/octet-stream)

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by charprap (Submitted the item)
  • -email is unavailable- added by charprap
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 25 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-30 mtmiller StatusPatch Reviewed => Fixed
        Open/ClosedOpen => Closed
    2018-04-12 charprap Attached File- => Added buttord.m, #43897
        Attached File- => Added cheb1ord.m, #43898
        Attached File- => Added cheb2ord.m, #43899
    2018-04-12 charprap Attached File- => Added buttord.m, #43894
        Attached File- => Added cheb1ord.m, #43895
        Attached File- => Added cheb2ord.m, #43896
    2018-04-04 mtmiller Dependencies- => bugs #49514 is dependent
    2018-04-04 mtmiller Dependencies- => bugs #53205 is dependent
    2018-04-04 mtmiller Dependencies- => bugs #36521 is dependent
    2018-04-03 mtmiller StatusPatch Submitted => Patch Reviewed
    2017-08-14 mtmiller Summarysignal package: buttord, cheb1ord, cheb2ord : different errors => [octave forge] (signal) buttord, cheb1ord, cheb2ord : different errors
    2015-12-22 mtmiller StatusNone => Patch Submitted
        Assigned toNone => mtmiller
        Release4.0.0 => other
        Operating SystemMicrosoft Windows => Any
        Summarybuttord, cheb1ord, cheb2ord : different errors => signal package: buttord, cheb1ord, cheb2ord : different errors
    2015-12-05 charprap Attached File- => Added buttord.diff, #35643
        Attached File- => Added cheb1ord.diff, #35644
        Attached File- => Added cheb2ord.diff, #35645
    2015-11-14 charprap Attached File- => Added buttord_cheb1ord_cheb2ord.zip, #35457
        Attached File- => Added buttord.diff, #35458
        Attached File- => Added cheb1ord.diff, #35459
        Attached File- => Added cheb2ord.diff, #35460

    Back to the top


    Powered by Savane 3.5