bugGNU roff - Bugs: bug #44894, tmac/strip.sed : Add a comment to...

 
 

bug #44894: tmac/strip.sed : Add a comment to a created macro file

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Tue 21 Apr 2015 06:22:58 PM UTC
   
 
Category:  Macro - others/general Severity:  3 - Normal
Item Group:  Lint Status:  Fixed
Privacy:  Public Assigned to:  wl
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 24 Jan 2022 12:45:18 AM UTC, comment #6: 

Item Group should be "Lint", since the issue was with a comment in a generated file, not normally user-visible material (the concern of Item Group "Documentation").

G. Branden Robinson <gbranden>
Group administrator
Sat 22 Jan 2022 01:00:14 PM UTC, comment #5: 


commit 3177cd974857eef18140316a80a780af54671267
Author: Werner Lemberg <wl@gnu.org>
Date:   Wed Apr 22 07:55:34 2015 +0200

    Fix Savannah bug #44894.

    * tmac/strip.sed: Add a `generated file' warning.


And we did indeed finally kill the stripper.

commit ee41d36200ffc989eac09e65db7537bf59dd1c62
commit 24602f42e209e0565e778773a9d91c12eb3a921d
commit ac6080e394100a8ff441b0cb0101be9eb76331ca
commit f2f52b9afffb236a26e1d848192c2f2145cc4f56
commit 40cb44c083ebd9005ac4ddf94249ffb60497df26

G. Branden Robinson <gbranden>
Group administrator
Wed 22 Apr 2015 06:51:00 PM UTC, comment #4: 

Posting can always be done, regardless of the open/closed state.

Werner LEMBERG <wl>
Group administrator
Wed 22 Apr 2015 06:25:24 PM UTC, comment #3: 



>For some reasons, the original posting doesn't appear in the web interface,
>most probably due to incomplete markup.  Here it is.

  I put a '+verbatim+' in the first line, an empty line in the second

contribution starts with the '+verbatim+' tag und ends with a
'-verbatim-' tag to test the web interface.

N.B.  How to "Post a Comment" to a closed item (including (some of) the commented text)?
N.B.  My Subject turned up on the screen after I sent it, but I did not check the content.
-verbatim-

Bjarni Ingi Gislason <bjarniig>
Wed 22 Apr 2015 05:58:22 AM UTC, comment #2: 

I've applied it, thanks, replacing the `DO NOT MODIFY THIS FILE' with something softer, since users probably will change the stripped files to apply local modifications and adaptations.

Note that we are probably going to remove stripping completely, since today computers are fast enough (and harddisk space is abundant).

Werner LEMBERG <wl>
Group administrator
Wed 22 Apr 2015 05:41:00 AM UTC, comment #1: 

For some reasons, the original posting doesn't appear in the web interface, most probably due to incomplete markup.  Here it is.

Bjarni, if this happens again, please look up this link how to make your message appear verbatim, or to disable markup completely.  On the other hand, patches should be added as attachments, avoiding this issue completely.


From 115cd1b64a010c732e047afc0bb834916e817e84 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Tue, 21 Apr 2015 00:03:41 +0000
Subject: [PATCH] tmac/strip.sed: Add a comment to a created macro file

  The comment is analogous to those in created manpages, e.g. "info.1".
It is added after the first line as it might have a meaning.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 tmac/strip.sed |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tmac/strip.sed b/tmac/strip.sed
index 0bb59f8..907fb11 100644
--- a/tmac/strip.sed
+++ b/tmac/strip.sed
@@ -1,3 +1,6 @@
+2 i\
+.\\" DO NOT MODIFY THIS FILE!  It was generated by "tmac/strip.sed"\
+.\\" in the "groff" repository from a file with a "-u" suffix.
 # strip comments, spaces, etc., after a line containing `%beginstrip%'
 /%beginstrip%/,$ {
   s/^\.[        ]*/./
--
1.7.1


Werner LEMBERG <wl>
Group administrator
Tue 21 Apr 2015 06:22:58 PM UTC, original submission:  



From 115cd1b64a010c732e047afc0bb834916e817e84 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Tue, 21 Apr 2015 00:03:41 +0000
Subject: [PATCH] tmac/strip.sed: Add a comment to a created macro file

  The comment is analogous to those in created manpages, e.g. "info.1".
It is added after the first line as it might have a meaning.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 tmac/strip.sed |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/tmac/strip.sed b/tmac/strip.sed
index 0bb59f8..907fb11 100644
--- a/tmac/strip.sed
+++ b/tmac/strip.sed
@@ -1,3 +1,6 @@
+2 i\
+.\\" DO NOT MODIFY THIS FILE!  It was generated by "tmac/strip.sed"\
+.\\" in the "groff" repository from a file with a "-u" suffix.
 # strip comments, spaces, etc., after a line containing `%beginstrip%'
 /%beginstrip%/,$ {
   s/^\.[        ]*/./
--
1.7.1

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-24 gbranden Item GroupDocumentation Lint
    2022-01-22 gbranden CategoryNone Macro - others/general
        Item GroupNone Documentation
    2015-04-22 wl StatusNone Fixed
        Assigned toNone wl
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code