bugGNU roff - Bugs: bug #44767, grog(1) - build fails to...

 
 

bug #44767: grog(1) - build fails to substitute @grog_dir@ in generation of grog from src/roff/grog/grog.pl

Submitter:  None
Submitted:  Wed 08 Apr 2015 02:41:30 AM UTC
   
 
Category:  Utilities Severity:  3 - Normal
Item Group:  Incorrect behaviour Status:  Fixed
Privacy:  Public Assigned to:  wl
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 02 May 2022 01:24:38 AM UTC, comment #2: 


commit 3fbf0d1d311152842ff7262ccaf9978ecac62c52
Author: Werner Lemberg <wl@gnu.org>
Date:   Wed Apr 8 08:56:06 2015 +0200

    Fix Savannah bug #44767.
    Patch by Peter Bray.

    * src/roff/grog/grog.am (grog): Correctly substitute `grog_dir'.


G. Branden Robinson <gbranden>
Group administrator
Wed 08 Apr 2015 06:56:47 AM UTC, comment #1: 

Applied, thanks!

Werner LEMBERG <wl>
Group administrator
Wed 08 Apr 2015 02:41:30 AM UTC, original submission:  

Greetings,

When building the git version of groff (2015/04/04) to check the fix
for https://savannah.gnu.org/bugs/?44708, I discovered that the
installed grog(1) did not function, with the error:

@grog_dir@ is not an existing directory; at /pkgs/64-bit/release/groff-git_2014_04_04/bin/grog line 73.

Investigation showed that grog is constructed in the top-level
directory by the makefile fragment shown at the end of this message.

This makefile fragment comes from src/roff/grog/grog.am, which fails
to substitute the the string @grog_dir@ for $(grog_dir). The following
patch shows a possible solution to the issue.

--- ./src/roff/grog/grog.am.orig        2015-04-08 12:28:32.847135446 +1000
+++ ./src/roff/grog/grog.am     2015-04-08 12:29:19.132059779 +1000
@@ -43,6 +43,7 @@
            -e "s|[@]libdir[@]|$(DESTDIR)$(libdir)|g" \
            -e "s|[@]EGREP[@]|$(EGREP)|g" \
            -e "s|[@]VERSION[@]|$(VERSION)|" \
+           -e "s|[@]grog_dir[@]|$(grog_dir)|" \
            -e "$(SH_SCRIPT_SED_CMD)" \
            $(grog_srcdir)/grog.pl >$@
        chmod +x $@

Regards,
Peter Bray
Sydney, Australia


Sample Git Build, only relevant out shown (made 80 column friendly):

bash  ./bootstrap
./configure --prefix=${INSTALLATION_PREFIX} \
--with-libiconv-prefix=${PKGS_BASE_PREFIX} \
--with-doc=yes --without-x
gmake
rm grog
gmake
gmake  all-am
gmake[1]: Entering directory `/tmp/64-bit/groff-git_2014_04_04'
rm -f grog
sed -f "./shdeps.sed" \
    -e "1s|^\(#! \).*perl|\\1/pkgs/64-bit/bin/perl|" \
    -e "s|[@]g[@]|g|g" \
    -e "s|[@]BINDIR[@]|/pkgs/64-bit/release/groff-git_2014_04_04/bin|g" \
    -e "s|[@]libdir[@]|/pkgs/64-bit/release/groff-git_2014_04_04/lib|g" \
    -e "s|[@]EGREP[@]|/pkgs/64-bit/bin/ggrep -E|g" \
    -e "s|[@]VERSION[@]|1.22.3|" \
    -e "1s/a/a/" \
    ./src/roff/grog/grog.pl >grog
chmod +x grog
gmake[1]: Leaving directory `/tmp/64-bit/groff-git_2014_04_04'

Corresponding generated Makefile fragment:

grog: $(grog_srcdir)/grog.pl $(GROG) $(SH_DEPS_SED_SCRIPT)
        $(RM) $@
        sed -f "$(SH_DEPS_SED_SCRIPT)" \
            -e "1s|^\(#! \).*perl|\\1$(PERL)|" \
            -e "s|[@]g[@]|$(g)|g" \
            -e "s|[@]BINDIR[@]|$(DESTDIR)$(bindir)|g" \
            -e "s|[@]libdir[@]|$(DESTDIR)$(libdir)|g" \
            -e "s|[@]EGREP[@]|$(EGREP)|g" \
            -e "s|[@]VERSION[@]|$(VERSION)|" \
            -e "$(SH_SCRIPT_SED_CMD)" \
            $(grog_srcdir)/grog.pl >$@
        chmod +x $@

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by wl (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-05-02 gbranden CategoryNone Utilities
    2015-04-08 wl StatusNone Fixed
        Assigned toNone wl
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code