bugGNU Octave - Bugs: bug #43385, Fix using uninitialized variable...

 
 

bug #43385: Fix using uninitialized variable (lo_specfun.cc)

Submitter:  PrasannaKumar Muralidharan <prasannatsm>
Submitted:  Wed 08 Oct 2014 05:33:35 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Wont Fix Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 11 Oct 2014 04:35:17 AM UTC, comment #3: 

As 'retval' is passed by reference the analyser was not able to determine whether it is input or output variable.

There is no use of this patch. Sorry for the noise.

PrasannaKumar Muralidharan <prasannatsm>
Thu 09 Oct 2014 09:19:16 PM UTC, comment #2: 

Since retval is declared float in your patch, you should be assigning octave_Float_NaN instead of octave_NaN.

But I'm not sure this patch is really needed.  The third argument to xsgammainc is supposed to be an output variable that is always set on a successful call.  Is that not the case?  If not, is it any different from xgammainc?

John W. Eaton <jwe>
Group administrator
Thu 09 Oct 2014 12:30:51 PM UTC, comment #1: 

Duplicate of #43383

Ben Abbott <bpabbott>
Group Member
Wed 08 Oct 2014 05:33:35 PM UTC, original submission:  

Attached patch fixes usage of uninitialised variable.

PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by bpabbott (Posted a comment)
  • -email is unavailable- added by prasannatsm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-10-21 rik5 StatusNone Wont Fix
        Open/ClosedOpen Closed
    2014-10-09 bpabbott StatusDuplicate None
        Open/ClosedClosed Open
        SummaryFix using uninitialised variable Fix using uninitialized variable (lo_specfun.cc)
    2014-10-09 bpabbott StatusNone Duplicate
        Open/ClosedOpen Closed
    2014-10-08 prasannatsm Attached File- Added fix_uninitialised_memory_access_lo-specfun_cc.diff, #32244

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code