bugGNU Health - Bugs: bug #43317, Use origin on InvoiceLine

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43317: Use origin on InvoiceLine

Submitted by:  Cédric Krier <cedk>
Submitted on:  Sun 28 Sep 2014 12:56:14 PM UTC  
 
Category:  Functionality Severity:  1 - Wish
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Chris Zimmerman <teffalump>
Open/Closed:  Closed Release:  2.9.0
Module:  health_services

( Jump to the original submission)

Fri 08 May 2015 12:05:00 AM UTC, comment #6: 

I just added a commit to prevent write and delete functions from executing for service lines of invoiced items. Along with the previous commit to make the patient readonly, these changes should prevent any of the function fields from displaying incorrect or modified information. Unless I'm mistaken, this issue is fixed and closed. =-)

Chris Zimmerman <teffalump>
Project MemberIn charge of this item.
Tue 05 May 2015 12:50:32 AM UTC, comment #5: 

Yeah, you are right. I just noticed that it is possible to change the patient on an invoiced health_services item and have that change affect the invoice. Not good. However, from what I understand, the patient field on the health_services model is the only field that can have that effect. I pushed a commit to fix that. However, I'm wondering if all the fields should be read-only after the invoice?

Chris Zimmerman <teffalump>
Project MemberIn charge of this item.
Mon 04 May 2015 11:56:21 PM UTC, comment #4: 

Yep, thanks for that!

Chris Zimmerman <teffalump>
Project MemberIn charge of this item.
Sat 02 May 2015 06:18:17 PM UTC, comment #3: 

Thank you, Chris !

I just tested and it looks great. I like the idea of the functional fields, and using the origin field.

What we should do now is, once the service has been invoiced,  make read-only those fields coming from the health services model that are used as the source to the functional fields in the invoice module.

PS: Just added missing imports (Transaction and backend), probably slipped from the patch file.

Best,

Luis Falcon <meanmicio>
Project Administrator
Fri 01 May 2015 04:17:26 AM UTC, comment #2: 

I was looking at this report and wrote a patch that uses the origin field of InvoiceLine and moves both health_service and patient fields to Function types. The health_service and patient fields query the origin field for patient and health_service values - it is a bit awkward, but it seems to work. Thoughts? Suggestions?

(file #33852)

Chris Zimmerman <teffalump>
Project MemberIn charge of this item.
Sun 28 Sep 2014 04:27:06 PM UTC, comment #1: 

Ok, I agree, Do you thinking take action? or it would be assigned to me.

oscar alvarez <oscar_alv>
Sun 28 Sep 2014 12:56:14 PM UTC, original submission:  

Instead of adding a new field on Invoice, health_services could re-use the origin field on InvoiceLine and replace the patient field by a Function field.
This will let the Invoice usage more generic and re-use existing functionalities of Tryton.

Cédric Krier <cedk>

 

Attached Files
file #33852:  patch.diff added by teffalump (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by teffalump (Updated the item)
  • -email is unavailable- added by meanmicio (Updated the item)
  • -email is unavailable- added by oscar_alv (Posted a comment)
  • -email is unavailable- added by cedk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-05-08 teffalump StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2015-05-02 meanmicio StatusNone => In Progress
        Assigned tooscar_alv => teffalump
    2015-05-01 teffalump Attached File- => Added patch.diff, #33852
        Release2.7.0 => 2.9.0
    2014-10-02 meanmicio Assigned toNone => oscar_alv
    2014-10-02 cedk Assigned tocedk => None
    2014-10-02 meanmicio CategoryNone => Functionality
    2014-10-02 meanmicio Assigned toNone => cedk
        ReleaseNone => 2.7.0

    Back to the top


    Powered by Savane 3.5