bugGnash - The GNU Flash player - Bugs: bug #43198, Build process is stopped in...

 
 

bug #43198: Build process is stopped in ASHandlers.cpp

Submitted by:  Frederic Bezies <fredbezies>
Submitted on:  Thu Sep 11 15:32:09 2014  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun Feb 1 21:48:07 2015, comment #10:

Builds fine on openSUSE:
https://pmbs.links2linux.de/package/show/Essentials/gnash

Anonymous
Sun Feb 1 19:48:18 2015, comment #9:

Should be fixed in 4a9aa74.

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun Feb 1 17:40:40 2015, comment #8:

fails: boost-devel-1.57.0-2.fc21.x86_64 + gcc-c++-4.9.2-1.fc21.x86_64

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun Feb 1 16:16:26 2015, comment #7:

works: boost-1.55.0-8.fc21.x86_64 + gcc-c++-4.9.2-1.fc21.x86_64

So maybe it's just boost >= 1.56?

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Sun Feb 1 15:22:50 2015, comment #6:

It seems to be a problem with boost > 1.54.0:

on openSUSE:
working: boost 1.54.0 + gcc 4.8.3+r212056 (openSUSE_13.2)
failing: boost 1.56.0 + gcc 4.8.3+r218481 (Factory)

See:
https://pmbs.links2linux.de/package/show/Essentials/gnash

Anonymous
Wed Oct 15 18:12:34 2014, comment #5:

I'm actually surprised abot the problem you initially have:
cannot convert 'const boost::optional<gnash::SWFRect>' to 'bool'

Converting boost::optional to bool is one of the main goals for that class, so could it be a problem with GCC 4.9.1-2 and boost (which version ?) ?

Sandro Santilli <strk>
Project Member
Wed Oct 15 16:46:55 2014, comment #4:

Okay, I did manage to get it to build with the change, but I'm using gcc 4.9.1-2. If anyone else has the same problem, they can try the workaround.

It's odd that the comparison would cause a failure, though. But I'm not C savvy enough to try and fix it without much trial and error.

Tim Van den Langenbergh <tmtvl>
Wed Oct 15 16:35:24 2014, comment #3:

My failure was actually due to the change, so I reverted it as of
commit d821b4c9abbbabf03491a2cb0a02ebeeda4d5360

Sandro Santilli <strk>
Project Member
Wed Oct 15 16:26:37 2014, comment #2:

I've pushed the hasBounds() change with commit ace2e81f36f6c4d266e0c63a1c95cc23d3d45567

But build still fails for me later with GCC 4.8.2:

In file included from /usr/include/boost/optional/optional.hpp:36:0,
from /usr/include/boost/optional.hpp:15,
from /usr/include/boost/format/internals.hpp:20,
from /usr/include/boost/format.hpp:38,
from /usr/include/boost/math/policies/error_handling.hpp:31,
from /usr/include/boost/math/special_functions/gamma.hpp:21,
from /usr/include/boost/math/special_functions/detail/bessel_jy.hpp:14,
from /usr/include/boost/math/special_functions/bessel.hpp:18,
from /usr/include/boost/math/special_functions/airy.hpp:10,
from /usr/include/boost/math/special_functions.hpp:15,
from /usr/include/boost/random/generate_canonical.hpp:22,
from /usr/include/boost/random.hpp:52,
from /usr/src/gnash/gnash-head/libcore/vm/ASHandlers.cpp:29:
/usr/include/boost/utility/compare_pointees.hpp: In instantiation of 'bool boost::equal_pointees(const OptionalPointee&, const OptionalPointee&) [with OptionalPointee = boost::optional<gnash::SWFRect>]':
/usr/include/boost/optional/optional.hpp:894:41: required from 'bool boost::operator==(boost::none_t, const boost::optional<T>&) [with T = gnash::SWFRect; boost::none_t = int boost::detail::none_helper::*]'
/usr/include/boost/optional/optional.hpp:904:15: required from 'bool boost::operator!=(boost::none_t, const boost::optional<T>&) [with T = gnash::SWFRect; boost::none_t = int boost::detail::none_helper::*]'
/usr/src/gnash/gnash-head/libcore/DragState.h:65:22: required from here
/usr/include/boost/utility/compare_pointees.hpp:32:52: error: no match for 'operator==' (operand types are 'const gnash::SWFRect' and 'const gnash::SWFRect')
return (!x) != (!y) ? false : ( !x ? true : (x) == (y) ) ;
^

Sandro Santilli <strk>
Project Member
Wed Oct 15 15:51:59 2014, comment #1:

A possible workaround could be to edit libcore/DragState.h:64:
bool hasBounds() const {
-return (_bounds);
+return (NULL != _bounds);
}

As this returns a boolean instead of an object.

Tim Van den Langenbergh <tmtvl>
Thu Sep 11 15:32:09 2014, original submission:

I was trying to build gnash from git sources after bug #42574 was declared as fixed, but building process crashed.

Here is the log I got right before crash :

" CXXLD libgnashparser.la
make[4]: Leaving directory '/home/fred/gnash-trunk-git/src/gnash/libcore/parser'
Making all in vm
make[4]: Entering directory '/home/fred/gnash-trunk-git/src/gnash/libcore/vm'
CXX ASHandlers.lo
In file included from ASHandlers.cpp:46:0:
../../libcore/DragState.h: In member function 'bool gnash::DragState::hasBounds() const':
../../libcore/DragState.h:65:24: error: cannot convert 'const boost::optional<gnash::SWFRect>' to 'bool' in return
return (_bounds);
^
Makefile:757: recipe for target 'ASHandlers.lo' failed
make[4]: *** [ASHandlers.lo] Error 1
make[4]: Leaving directory '/home/fred/gnash-trunk-git/src/gnash/libcore/vm'
Makefile:2381: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/home/fred/gnash-trunk-git/src/gnash/libcore'
Makefile:1246: recipe for target 'all' failed
make[2]: *** [all] Error 2"

Boost version : 1.56
Gcc : 4.9.1

Frederic Bezies <fredbezies>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by tmtvl (Posted a comment)
  • -unavailable- added by kozross (Interested in resolution)
  • -unavailable- added by fredbezies (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Feb 1 22:28:58 2015bjacquesStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun Feb 1 19:48:18 2015bjacquesStatusNone=>Ready For Test
    Sun Feb 1 18:03:54 2015bjacquesAssigned toNone=>bjacques
    Wed Oct 15 16:35:29 2014strkSeverity5 - Blocker=>3 - Normal
    Wed Oct 15 16:26:37 2014strkCategoryNone=>build
      Severity3 - Normal=>5 - Blocker
    Thu Sep 11 21:30:52 2014kozrossCarbon-Copy-=>Added kozross

    Back to the top


    Powered by Savane 3.1-cleanup