bugGNU Wget - Bugs: bug #42953, CSS URI parser broken


bug #42953: CSS URI parser broken

Submitted by:  None
Submitted on:  Sat 09 Aug 2014 04:01:27 PM UTC  
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Originator Name: AtomicDryadOriginator Email: -unavailable-
Open/Closed: OpenRelease: trunk
Operating System: GNU/LinuxReproducibility: Every Time
Fixed Release: NonePlanned Release: None
Regression: NoneWork Required: None
Patch Included: Yes

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat 09 Aug 2014 04:01:27 PM UTC, original submission:

Since the commit 8e6de1f on 2014-06-09 the CSS parser fails to trim url() entries, specifically everything past ')' like this:
# ./src/wget http://www.cpan.org/misc/css/cpan.css -qO-|grep -m1 url
background: white url(../images/bg_gradient.jpg) repeat-x left top;

This causes:
# ./src/wget -p -k -E http://www.cpan.org 2>&1|grep ';'
--2014-08-09 09:58:21-- http://www.cpan.org/misc/images/bg_gradient.jpg)%20repeat-x%20left%20top;%0A%20%20%20%20max-width:%2070em;%0A%7D%0Atd

I'm attaching a patch which changes xstrdup to xmemdup, with the relevent length parameter.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #31879:  really-fix-css.diff added by None (618B - application/octet-stream - Oops, using xmemdup that way resulted in corrupted string)
file #31878:  fix-css.diff added by None (298B - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by None (Submitted the item)

    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 09 Aug 2014 04:41:19 PM UTCNoneAttached File-=>Added really-fix-css.diff, #31879
    Sat 09 Aug 2014 04:01:27 PM UTCNoneAttached File-=>Added fix-css.diff, #31878

    Back to the top

    Powered by Savane 3.1-cleanup