bugGNU roff - Bugs: bug #42190, "grops -c a" dumps core

 
 

bug #42190: "grops -c a" dumps core

Submitter:  Rich Burridge <richburridge>
Submitted:  Thu 24 Apr 2014 09:16:27 PM UTC
   
 
Category:  Driver grops Severity:  4 - Important
Item Group:  Crash/Unresponsive Status:  Fixed
Privacy:  Public Assigned to:  carstenkunze
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 01 Apr 2023 02:39:58 PM UTC, comment #2: 


commit bc85af4016824b6bf97f859e16722486a548ab03
Author:     Rich Burridge <richburridge>
AuthorDate: Fri Apr 28 21:48:21 2017 +0200
Commit:     Rich Burridge <richburridge>
CommitDate: Fri Apr 28 21:48:21 2017 +0200

    "grops -c a" dumps core

    errprint() uses %1 etc. instead of %s

    Fixes https://savannah.gnu.org/bugs/?42190


G. Branden Robinson <gbranden>
Group administrator
Mon 26 Nov 2018 11:46:33 PM UTC, comment #1: 

Was fixed last year.

Bertrand Garrigues <bgarrigues>
Group administrator
Thu 24 Apr 2014 09:16:27 PM UTC, original submission:  

Steps to reproduce:

  $ /usr/bin/grops -c a

This will dump core.

Fix is:

--- groff-1.22.2/src/devices/grops/ps.cpp.orig  2014-04-24 06:01:32.421674773 -0700
+++ groff-1.22.2/src/devices/grops/ps.cpp       2014-04-24 09:27:56.445423217 -0700
@@ -1803,7 +1803,7 @@
       break;
     case 'c':
       if (sscanf(optarg, "%d", &ncopies) != 1 || ncopies <= 0) {
-       error("bad number of copies `%s'", optarg);
+       error("bad number of copies `%1'", optarg);
        ncopies = 1;
       }
       break;

(this is a patch against groff 1.22).

Thanks.

Rich Burridge <richburridge>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bgarrigues (Posted a comment)
  • -email is unavailable- added by carstenkunze (Updated the item)
  • -email is unavailable- added by richburridge (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-04-01 gbranden Severity3 - Normal 4 - Important
        Planned ReleaseNone 1.22.4
        Summary/usr/bin/grops -c a core dumps "grops -c a" dumps core
    2018-11-26 bgarrigues CategoryNone Driver grops
        Item GroupNone Crash/Unresponsive
        StatusReady for Merge Fixed
        Open/ClosedOpen Closed
    2017-04-28 carstenkunze StatusNone Ready for Merge
        Assigned toNone carstenkunze

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code