bugGNU Octave - Bugs: bug #41984, Package Image 2.2.1 (imsmooth)-...

 
 

bug #41984: Package Image 2.2.1 (imsmooth)- bug into the Bilateral filter

Submitter:  Marc Vivet <marcvivet>
Submitted:  Thu 27 Mar 2014 10:54:16 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Inaccurate Result
Status:  Fixed Assigned to:  None
Originator Name:  Marc Vivet Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 26 Mar 2015 12:14:51 AM UTC, comment #4: 

Awesome. Thank you for the patch. I have pushed as http://hg.code.sf.net/p/octave/image/rev/6a8da9c2a391

Carnë Draug <carandraug>
Group Member
Sun 22 Mar 2015 06:59:24 PM UTC, comment #3: 


Bug fix + test for bilateral filter attached.


(file #33420)

Avinoam Kalma <avinoam>
Group Member
Thu 19 Mar 2015 11:06:47 PM UTC, comment #2: 

Could you add a test for imsmooth on your cset as well? I will then push this.

Carnë Draug <carandraug>
Group Member
Thu 19 Mar 2015 08:30:15 PM UTC, comment #1: 


The problem is in line 71 of __bilateral__.cc: val[i] should im(r+s,c+s,i).

changeset attached.


(file #33401)

Avinoam Kalma <avinoam>
Group Member
Thu 27 Mar 2014 10:54:16 PM UTC, original submission:  

When using the function imsmooth configured to perform a Bilateral filter, results in a shifted image.

For instance:

ima_out = imsmooth(ima_in, 'Bilateral', 2, 10);

where ima_in is the input image, 2 is the spatial sigma and 10 is the range sigma.

This causes that ima_out is not aligned to ima_in.

The problem seems to be caused by the file _bilateral_.cc and the amount of shift is proportinal to the spatial sigma for the X and Y axis.

It can be computed as <spatial sigma>*3 on the X and Y axes.

Marc Vivet <marcvivet>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33420:  bilateral2.patch added by avinoam (2KiB - application/octet-stream)
file #33401:  bilateral.patch added by avinoam (818B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Updated the item)
  • -email is unavailable- added by marcvivet (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-26 carandraug Open/ClosedOpen Closed
        Operating SystemMicrosoft Windows Any
    2015-03-26 carandraug StatusNone Fixed
    2015-03-22 avinoam Attached File- Added bilateral2.patch, #33420
    2015-03-19 carandraug Release3.8.1 other
    2015-03-19 avinoam Attached File- Added bilateral.patch, #33401

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code