bugGNU Wget - Bugs: bug #41235, wget fixes for various Parfait...

 
 

bug #41235: wget fixes for various Parfait errors

Submitted by:  Jiri Kukacka <kukackajiri>
Submitted on:  Tue 14 Jan 2014 04:47:04 PM UTC  
 
Category: Memory LeakSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Open
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: None
Planned Release: NoneRegression: None
Work Required: NonePatch Included: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 17 Jan 2014 05:59:42 AM UTC, comment #1:

Thanks for the submission Jiri. The reported errors are all checks for NULL pointers.

While checking for NULL on hash_table_get() seems like a sane idea to me and should be implemented, I am not sure it is required in a few other places. Sometimes, the checks are already done in another function, and we are assured of non-NULL values here. I'd have to dig into the code deeper to figure those out.

However, could you please re-submit your patch formatting it along the GNU coding style?

Darshit Shah <darnir>
Project Member
Tue 14 Jan 2014 04:47:04 PM UTC, original submission:

Hello,
I found out various problems in wget version 1.14 using Parfait static code analysis, so I include patch to fix it.
Hope it helps,
Jiri

Jiri Kukacka <kukackajiri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30273:  02-parfait_errors_fix.patch added by kukackajiri (1kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by darnir (Posted a comment)
  • -unavailable- added by darnir
  • -unavailable- added by kukackajiri (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 17 Jan 2014 05:53:44 AM UTCdarnirCarbon-Copy-=>Added -unavailable-
    Tue 14 Jan 2014 04:47:05 PM UTCkukackajiriAttached File-=>Added 02-parfait_errors_fix.patch, #30273

    Back to the top


    Powered by Savane 3.1-cleanup