bugGNU Octave - Bugs: bug #41209, missing CPPFLAGS in umfpack tests

 
 

bug #41209: missing CPPFLAGS in umfpack tests

Submitter:  None
Submitted:  Sun 12 Jan 2014 07:34:42 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Kyle Guinn Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 3.8.0
Operating System:  * GNU/Linux Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 13 Jan 2014 04:11:39 PM UTC, comment #3: 

I pushed the changeset to the stable branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/975480e1be4b).  It will be part of the 3.8.1 bug fix release.

Rik <rik5>
Group administrator
Mon 13 Jan 2014 05:03:20 AM UTC, comment #2: 

That attribution works for me.  Thanks for applying it!

Anonymous
Sun 12 Jan 2014 10:32:58 PM UTC, comment #1: 

The patch looks sensible.  We usually credit the people who contribute using the format name <e-mail address> so

Kyle Guinn <elyk03@gmail.com>

Is that okay or would prefer to be anonymous?

Rik <rik5>
Group administrator
Sun 12 Jan 2014 07:34:42 AM UTC, original submission:  

Some of configure's feature tests against umfpack do not provide all the necessary CPPFLAGS for umfpack.  Those tests will fail, for example, if you have headers in some non-default location and need to add -I flags.

configure:37239: checking whether UMFPACK needs SuiteSparse_time function
...
In file included from conftest.c:101:0:
/usr/include/umfpack/umfpack.h:89:17: fatal error: amd.h: No such file or directory
 #include "amd.h"
...
configure:37297: result: yes

The result should be 'no' for my system, and it's only 'yes' because of this one error.  The next check for "UMFPACK separate complex matrix and rhs split" fails similarly.

I've attached a patch that fixes it.  The important thing is to add AMD_CPPFLAGS since umfpack.h depends on amd.h, and the check for the umfpack library does the same thing.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30250:  umfpack-cppflags.diff added by None (1011B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-13 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2014-01-12 rik5 StatusNone Patch Submitted
    2014-01-12 None Attached File- Added umfpack-cppflags.diff, #30250

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code