bugDDD - Bugs: bug #40701, layout.C: 2 * bad if test ?

 
 

bug #40701: layout.C: 2 * bad if test ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Mon 25 Nov 2013 03:08:31 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 25 Nov 2013 03:08:31 PM UTC, original submission:

I just ran the static analyser cppcheck over the source
code of ddd-3.3.12. It said

1.

[layout.C:1338] -> [layout.C:1338]: (style) Same expression on both sides of '&&'.

Source code is

if (node->hashprev && node->hashprev) {
node->hashprev->hashnext = node->hashnext;
node->hashnext->hashprev = node->hashprev;

I think

if (node->hashprev && node->hashnext) {
node->hashprev->hashnext = node->hashnext;
node->hashnext->hashprev = node->hashprev;

might be better code.

2.

[layout.C:1796] -> [layout.C:1796]: (style) Same expression on both sides of '&&'.

if (graph->hashprev && graph->hashprev) {
graph->hashprev->hashnext = graph->hashnext;
graph->hashnext->hashprev = graph->hashprev;

Duplicate.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup