bugDDD - Bugs: bug #40701, layout.C: 2 * bad if test ?


bug #40701: layout.C: 2 * bad if test ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Mon 25 Nov 2013 03:08:31 PM UTC  
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Release:  None

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 25 Nov 2013 03:08:31 PM UTC, original submission:  

I just ran the static analyser cppcheck over the source
code of ddd-3.3.12. It said


[layout.C:1338] -> [layout.C:1338]: (style) Same expression on both sides of '&&'.

Source code is

    if (node->hashprev && node->hashprev) {
    node->hashprev->hashnext = node->hashnext;
    node->hashnext->hashprev = node->hashprev;

I think

    if (node->hashprev && node->hashnext) {
    node->hashprev->hashnext = node->hashnext;
    node->hashnext->hashprev = node->hashprev;

might be better code.


[layout.C:1796] -> [layout.C:1796]: (style) Same expression on both sides of '&&'.

    if (graph->hashprev && graph->hashprev) {
    graph->hashprev->hashnext = graph->hashnext;
    graph->hashnext->hashprev = graph->hashprev;


David Binderman <dcb314>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by dcb314 (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    No changes have been made to this item

    Back to the top

    Powered by Savane 3.7