bugGNU Octave - Bugs: bug #40636, GUI: file browser doesn't show...

 
 

bug #40636: GUI: file browser doesn't show hidden files with pref. set

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Tue 19 Nov 2013 08:11:39 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 21 Nov 2013 04:30:01 PM UTC, comment #7: 

I pushed the changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/f6e1be4ad923).  I added the bug number to the commit message and also made sure code lines were < 80 characters.

Rik <rik5>
Group administrator
Thu 21 Nov 2013 01:32:54 PM UTC, comment #6: 

I will push it (my) tonight unless someone else gets to it first.

John Donoghue <lostbard>
Group Member
Thu 21 Nov 2013 02:54:04 AM UTC, comment #5: 

Any chance this patch will make it into the 3.8 release? The only reason I ask is because for UI's it is generally bad to have a menu/preferences functionality that doesn't really do anything. It is just begging for people to ask why hidden files and directories are not shown, even though there appears to be an option for it.

John Swensen <jpswensen>
Wed 20 Nov 2013 08:01:39 PM UTC, comment #4: 

Patch works fine for me on Linux & Windows 8 & XP.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 20 Nov 2013 07:22:45 PM UTC, comment #3: 

works for me

John Donoghue <lostbard>
Group Member
Tue 19 Nov 2013 08:49:15 PM UTC, comment #2: 

This functionality wasn't implemented, but it was an easy fix. I think the following patch should implement the missing functionality.

(file #29665)

John Swensen <jpswensen>
Tue 19 Nov 2013 08:16:15 PM UTC, comment #1: 

Michael Goffioul's 3.7.2+ MSVC binary also has this bug.

Philip Nienhuis <philipnienhuis>
Group Member
Tue 19 Nov 2013 08:11:39 PM UTC, original submission:  

Although in Preferences | File browser (and with patch #8242) one can set "Show hidden files", those hidden files are never shown.

E.g. on Linux in the octave repo clone I expect to see .hg, .hgignore, etc.
Likewise, on Windows XP in C:\ I'd expect to see boot.ini, cmd.ldr and hiberfil.sys

Turns out this was already the case with Octave-3.7.5+ for MinGW (oldest dev version I have installed)

Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29665:  hiddenfiles.diff added by jpswensen (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by jpswensen (Updated the item)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-11-21 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2013-11-20 philipnienhuis StatusNone Patch Submitted
    2013-11-19 jpswensen Attached File- Added hiddenfiles.diff, #29665

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code