bugGNU Octave - Bugs: bug #40367, <pre> tag visible when using...

 
 

bug #40367: <pre> tag visible when using command line news

Submitter:  Rik <rik5>
Submitted:  Fri 25 Oct 2013 01:48:30 AM UTC
   
 
Category:  GUI Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 26 Oct 2013 04:42:56 AM UTC, comment #4: 

Ok, good idea, I incorporated that into this change and pushed

http://hg.savannah.gnu.org/hgweb/octave/rev/811b5a562680

Sorry for the delay.

Mike Miller <mtmiller>
Group Member
Fri 25 Oct 2013 01:22:24 PM UTC, comment #3: 

Mike, that change looks good to me.  You might want to also put an error message in the window if the file can't be opened or if it is empty so that there will be some clue about what happened.  If you don't have time to do that, then let me know and I will after you push your change to savannah.

Thanks!

John W. Eaton <jwe>
Group administrator
Fri 25 Oct 2013 01:12:16 PM UTC, comment #2: 

It doesn't have to be a URL. The function that takes URL is only used in that one place. Attached changeset works for me, merges those two functions and reads from a file instead of a URL. There's probably a Qt way to read a URL into a string but this works for NEWS as a local file.

(file #29467)

Mike Miller <mtmiller>
Group Member
Fri 25 Oct 2013 04:28:03 AM UTC, comment #1: 

I think the GUI just uses a file:/// URL, so no, it might not be so simple as just wrappeing in <pre> and </pre> tags, but we can certainly do something better.

John W. Eaton <jwe>
Group administrator
Fri 25 Oct 2013 01:48:30 AM UTC, original submission:  

In the CLI version of Octave, typing 'news', brings up the NEWS file which is now wrapped in


<pre> ... </pre>


tags.  This isn't horrible.  Still, it might be better to leave NEWS as a plain text file and wrap the pre tags around the text in news in the GUI.  I presume the GUI reads the file in as a string so it would be too hard to prepend, append the tags and then pass that text to the HTML viewer.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29467:  news.diff added by mtmiller (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-10-26 mtmiller StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2013-10-25 mtmiller Attached File- Added news.diff, #29467
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code