bugGNU Octave - Bugs: bug #40066, octave-dicom-0.1.1: 5 * off by one...

 
 

bug #40066: octave-dicom-0.1.1: 5 * off by one error ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Thu 19 Sep 2013 08:42:32 AM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  David Binderman Open/Closed:  Closed
Release:  other Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 23 Feb 2017 04:44:57 PM UTC, comment #4:

Closing as fixed - dicom 0.2.0 has been released

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 01 Feb 2017 06:02:52 PM UTC, comment #3:

Pushed change https://sourceforge.net/p/octave/dicom/ci/8ebccaee1d5eda41d05218c322bb97fea2dad33f/

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 23 Oct 2013 09:54:15 PM UTC, comment #2:

Added DICOM package maintainer to Mail Notification Carbon-Copy List.

Carnë Draug <carandraug>
Project Member
Tue 22 Oct 2013 01:16:30 AM UTC, comment #1:

Disclaimer: I know nothing about the dicom package.

Just had a quick look at the source lines mentioned in this report and the errors seem accurate, looks to me like an overrun waiting to happen.

Mike Miller <mtmiller>
Project Administrator
Thu 19 Sep 2013 08:42:32 AM UTC, original submission:

I just ran the static analysis tool "cppcheck" over
the source code of octave-dicom-0.1.1

It said

[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 1) is larger
than destination buffer 'tgroup[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 2) is larger
than destination buffer 'telem[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 3) is larger
than destination buffer 'tvr[8]', use %7s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 128 given in format string (no. 4) is large
r than destination buffer 'key[128]', use %127s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 5) is larger
than destination buffer 'tvm[8]', use %7s to prevent overflowing it.

The count doesn't include the trailing zero byte. Suggest code rework.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by carandraug (maintainer of DICOM package)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-02-23 lostbard StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2017-02-01 lostbard StatusConfirmed => Ready For Test
        Assigned toNone => lostbard
    2013-10-23 carandraug Carbon-Copy- => Added -email is unavailable-
    2013-10-22 mtmiller CategoryNone => Octave Forge Package
        StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.3