bugGNU Octave - Bugs: bug #40066, octave-dicom-0.1.1: 5 * off by one...

 
 

bug #40066: octave-dicom-0.1.1: 5 * off by one error ?

Submitted by:  David Binderman <dcb314>
Submitted on:  Thu 19 Sep 2013 08:42:32 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: ConfirmedAssigned to: None
Originator Name: David BindermanOpen/Closed: Open
Release: otherOperating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 23 Oct 2013 09:54:15 PM UTC, comment #2:

Added DICOM package maintainer to Mail Notification Carbon-Copy List.

Carnë Draug <carandraug>
Project Member
Tue 22 Oct 2013 01:16:30 AM UTC, comment #1:

Disclaimer: I know nothing about the dicom package.

Just had a quick look at the source lines mentioned in this report and the errors seem accurate, looks to me like an overrun waiting to happen.

Mike Miller <mtmiller>
Project Member
Thu 19 Sep 2013 08:42:32 AM UTC, original submission:

I just ran the static analysis tool "cppcheck" over
the source code of octave-dicom-0.1.1

It said

[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 1) is larger
than destination buffer 'tgroup[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 4 given in format string (no. 2) is larger
than destination buffer 'telem[4]', use %3s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 3) is larger
than destination buffer 'tvr[8]', use %7s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 128 given in format string (no. 4) is large
r than destination buffer 'key[128]', use %127s to prevent overflowing it.
[dicomdict.cpp:298]: (error) Width 8 given in format string (no. 5) is larger
than destination buffer 'tvm[8]', use %7s to prevent overflowing it.

The count doesn't include the trailing zero byte. Suggest code rework.

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by carandraug (maintainer of DICOM package)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by dcb314 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 23 Oct 2013 09:54:15 PM UTCcarandraugCarbon-Copy-=>Added -unavailable-
    Tue 22 Oct 2013 01:16:30 AM UTCmtmillerCategoryNone=>Octave Forge Package
      StatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup