bugGNU Wget - Bugs: bug #39453, Integer error/sign comparison bug...

 
 

bug #39453: Integer error/sign comparison bug causes wrapping error

Submitted by:  Will Dietz <dtzwill>
Submitted on:  Tue 09 Jul 2013 09:33:38 PM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Open/Closed: Closed
Release: trunkOperating System: None
Reproducibility: Every TimeFixed Release: None
Planned Release: 1.15Regression: None
Work Required: NonePatch Included: Yes

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 11 Aug 2013 02:05:16 AM UTC, comment #1:

This issue was fixed in http://git.savannah.gnu.org/cgit/wget.git/commit/?id=a12bd59111bd5e6fba91a8f1fa6c09698d03f740 and may now be closed.

Thanks!

Will Dietz <dtzwill>
Tue 09 Jul 2013 09:33:38 PM UTC, original submission:

Normal wrapping, with no token > line length, snippet from wget --version:

Link: gcc -DUNIMPORTANT_TEXT=123456789 -O2 -g -lgnutls -lgcrypt -lgpg-error
-lz -lz -lidn -luuid -lpcre ftp-opie.o gnutls.o ../lib/libgnu.a

However, if a token is longer than line length is present, an integer error causes wrapping to be disabled for subsequent tokens:

Link: gcc
-DUNIMPORTANT_TEXT_TO_CREATE_VERY_LONG_TOKEN_IN_FLAG_STRING=123456789 -O2 -g -lgnutls -lgcrypt -lgpg-error -lz -lz -lidn -luuid -lpcre ftp-opie.o gnutls.o ../lib/libgnu.a

The error occurs in src/main.c with both 1.14 and trunk, patch included.

Will Dietz <dtzwill>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28524:  0001-Fix-integer-error-in-format_and_print_line.patch added by dtzwill (1kB - text/x-patch - Suggested patch.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Updated the item)
  • -unavailable- added by dtzwill (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 02 Nov 2013 10:58:19 AM UTCgscrivanoStatusNone=>Fixed
      Assigned toNone=>gscrivano
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>1.15
    Tue 09 Jul 2013 09:33:38 PM UTCdtzwillAttached File-=>Added 0001-Fix-integer-error-in-format_and_print_line.patch, #28524

    Back to the top


    Powered by Savane 3.1-cleanup