bugGNU Octave - Bugs: bug #39345, symbolic package: Fix test in...

 
 

bug #39345: symbolic package: Fix test in sym2poly

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Wed 26 Jun 2013 04:06:00 PM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: Patch SubmittedAssigned to: None
Originator Name: Open/Closed: Open
Release: devOperating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 26 Jun 2013 08:12:47 PM UTC, comment #2:

You are right, the problem is not due to the fact that the arguments are cell arrays, but because the elements are symbolic expressions. For instance, this fails:

Anyway, the patch is still necessary. However, if you decide to apply it, please change the description.

Rafael Laboissiere <rlaboiss>
Wed 26 Jun 2013 05:52:44 PM UTC, comment #1:

I don't have the symbolic package to test this but does assert really fails on cell arrays? The following works fine on my system (dev version and 3.6.2).

Carnë Draug <carandraug>
Project Member
Wed 26 Jun 2013 04:06:00 PM UTC, original submission:

This bug was introduced by me in cset 46a454. The assert function does not support cells as arguments to be compared (observed and expected). This can be fixed by passing the string representation of both values, as in the patched attached to this bug report.

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28427:  fix-test-in-sym2poly.diff added by rlaboiss (875B - text/x-patch - Patch for inst/sym2poly.m)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 20 Jan 2014 04:46:07 AM UTCmtmillerStatusNone=>Patch Submitted
    Wed 26 Jun 2013 05:52:44 PM UTCcarandraugSummaryFix test in sym2poly=>symbolic package: Fix test in sym2poly
    Wed 26 Jun 2013 04:06:00 PM UTCrlaboissAttached File-=>Added fix-test-in-sym2poly.diff, #28427

    Back to the top


    Powered by Savane 3.1-cleanup