bugGNUstep - Bugs: bug #39081, Build error testing for blocks...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #39081: Build error testing for blocks runtime on Mac OS X

Submitted by:  Graham Lee <leeg>
Submitted on:  Mon 27 May 2013 04:25:39 PM UTC  
 
Category: Base/FoundationSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Fri 06 Sep 2013 08:43:33 AM UTC, comment #2:

I just sptted this report/patch and was about to apply it, when I found Fred already did it. It's in svn trunk. Thanks.

Richard Frith-Macdonald <CaS>
Project Member
Sun 04 Aug 2013 09:16:29 PM UTC, comment #1:

It looks like my patch was incorrect. the symbol is _APPLE_, two underscores on each side of the word.

Graham Lee <leeg>
Mon 27 May 2013 04:25:39 PM UTC, original submission:

As the diff shows, -base is checking for the wrong platform compatibility macro.

--- a/Headers/GNUstepBase/GSVersionMacros.h
+++ b/Headers/GNUstepBase/GSVersionMacros.h
@@ -313,7 +313,7 @@ static inline void gs_consumed(id NS_CONSUMED GS_UNUSED_ARG o) { return; }
*/
#if __has_feature(blocks)
# if OBJC2RUNTIME
-# if defined(APPLE)
+# if defined(_APPLE_)
# include <Block.h>
# else
# include <objc/blocks_runtime.h>

Graham Lee <leeg>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by CaS (Posted a comment)
  • -unavailable- added by leeg (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Sep 2013 08:43:33 AM UTCCaSStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup