bugGNU Octave - Bugs: bug #38755, io package 1.2.1: files under...

 
 

bug #38755: io package 1.2.1: files under private/ contain tests

Submitted by:  Sébastien Villemot <svillemot>
Submitted on:  Wed 17 Apr 2013 09:52:51 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: FixedAssigned to: Philip Nienhuis <philipnienhuis>
Originator Name: Open/Closed: Closed
Release: 3.6.4Operating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 19 Apr 2013 11:46:11 AM UTC, comment #4:

Given the discussion here:
https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2013-April/033225.html
and the links contained in it, I've concluded this "bug" has a much wider scope than just the io package.

As to io, I'm not happy with moving those tests away from the very functions they are supposed to test. So I simply commented out the tests in the private functions, until a better solution has been found.

Please contribute any comments to the discussion mentioned above, not here.

Thanks for reporting, IMO you've hit a valid issue.

Closing report

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Thu 18 Apr 2013 06:55:07 PM UTC, comment #3:

Moving discussion to maintainers ML.

I think this is something the Octave devs should decide as a community, rather than me deciding on my own.
As I read in
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=672756
more packages are affected as well, and Octave-core as well.

Status changed to "need info" (from maintainers ML)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 17 Apr 2013 08:07:14 PM UTC, comment #2:

Sure, you are in better position to decide what to do with these tests.

For me the important point is to move them away from private/.

Sébastien Villemot <svillemot>
Wed 17 Apr 2013 07:07:26 PM UTC, comment #1:

Wow, I didn't even remember I have ever made tests for these private funcs.

Thanks very much for your patch.
I'll have to think over what I should do with it. I'm planning to make a new bug fix release soon (I think early May I'll have time for it), most of the work has already been done, making the release is actually all that is needed.
Perhaps your patch better fits in with io-1.3.0+ planned to support next stable Octave 3.8+ (or 4.0, or whatever).

The tests you mention are OK but these days there's the io_xls_testscript.m & io_ods_testscript.m which are a sort of super test for all that the spreadsheet funcs should be able to do.
Probably these should be morphed into demos I suppose, but that is a long term goal as far as I'm concerned.

Just give me some time to think this over.

OS changed to "any", status to "patch submitted"

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 17 Apr 2013 09:52:51 AM UTC, original submission:

The following files under the private/ directory contain tests:
- inst/private/chk_jar_entries.m
- inst/private/parse_sp_range.m
- inst/private/spsh_prstype.m

Having tests in a file under private/ is a design flaw, because these tests cannot be executed with the test() command (unless the private/ subdir is added to the path, which is precisely against its purpose).

The attached patch (applied to the Debian package) proposes a solution by running the tests from related upper-level functions.

This is needed for Debian because we run the testsuite at build time.

Sébastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by svillemot (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 19 Apr 2013 11:46:11 AM UTCphilipnienhuisStatusNeed Info=>Fixed
      Assigned toNone=>philipnienhuis
      Open/ClosedOpen=>Closed
    Thu 18 Apr 2013 06:55:07 PM UTCphilipnienhuisStatusPatch Submitted=>Need Info
    Wed 17 Apr 2013 07:07:26 PM UTCphilipnienhuisStatusNone=>Patch Submitted
      Operating SystemGNU/Linux=>Any
    Wed 17 Apr 2013 09:52:51 AM UTCsvillemotAttached File-=>Added private-testsuite.patch, #27896

    Back to the top


    Powered by Savane 3.1-cleanup